Skip to content

bridge: json and color support

Stephen Hemminger netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v14 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5bridge: implement json pretty print flagbridge/br_common.h bridge/bridge.c bridge/fdb.c +3 more+35 -140 replies
2/5bridge: colorize output and use JSON print librarybridge/br_common.h bridge/bridge.c bridge/fdb.c +2 more+363 -5683 replies
3/5bridge: add json support for link commandbridge/link.c+132 -1130 replies
4/5bridge: update man page for new color and json changesman/man8/bridge.8+8 -30 replies
5/5ip: always print interface name in colorbridge/link.c include/utils.h ip/ipaddress.c +1 more+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 iproute2-next 0/5] bridge: json and color support

From: Stephen Hemminger <[email protected]>

This set of patches adds color and full JSON support to bridge command.

The output format for bridge link command changes so that

  $ bridge link show
and
  $ ip link show
use same basic format.

The "-c" flag to bridge changes from shortened form of "-compressvlan" to shortened form of "-color". Once again this is so that ip and bridge command take similar options.

Lastly the JSON output format changes slightly but this could not impact any real user, because in several cases the current format was invalid JSON!

v2
rebase to updated iproute2-next
use common pretty flag
use common print_name_and_link

Stephen Hemminger (5):
bridge: implement json pretty print flag
bridge: colorize output and use JSON print library
bridge: add json support for link command
bridge: update man page for new color and json changes
ip: always print interface name in color

 bridge/br_common.h |   4 +-
 bridge/bridge.c    |  16 ++-
 bridge/fdb.c       | 279 ++++++++++++++++-------------------------
 bridge/link.c      | 245 +++++++++++++++++++-----------------
 bridge/mdb.c       | 354 ++++++++++++++++++++++-------------------------------
 bridge/vlan.c      | 279 ++++++++++++++++-------------------------
 include/utils.h    |   2 +-
 ip/ipaddress.c     |   4 +-
 lib/utils.c        |   4 +-
 man/man8/bridge.8  |  15 ++-
 10 files changed, 521 insertions(+), 681 deletions(-)
Signature · 1 line
2.16.1