tcp: remove non GSO code
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tcp: switch to GSO being always oninclude/ net/ net/ | +3 | 0 replies | |
| 2/6 | tcp: remove sk_can_gso() usenet/ net/ | +8 | 0 replies | |
| 3/6 | tcp: remove sk_check_csum_caps()include/ net/ | +3 | 0 replies | |
| 4/6 | tcp: tcp_sendmsg() only deals with CHECKSUM_PARTIALnet/ | +3 | 0 replies | |
| 5/6 | tcp: remove dead code from tcp_set_skb_tso_segs()net/ | +1 | 0 replies | |
| 6/6 | tcp: remove dead code after CHECKSUM_PARTIAL adoptionnet/ net/ | +8 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Soheil Hassas Yeganeh | Neal Cardwell |
|---|---|---|
| Series | A-b A-b | A-b |
| 1/6 | ||
| 2/6 | ||
| 3/6 | ||
| 4/6 | ||
| 5/6 | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/6] tcp: remove non GSO code
Switching TCP to GSO mode, relying on core networking layers to perform eventual adaptation for dumb devices was overdue.
1) Most TCP developments are done with TSO in mind.
2) Less high-resolution timers needs to be armed for TCP-pacing
3) GSO can benefit of xmit_more hint
4) Receiver GRO is more effective (as if TSO was used for real on sender) -> less ACK packets and overhead.
5) Write queues have less overhead (one skb holds about 64KB of payload)
6) SACK coalescing just works. (no payload in skb->head)
7) rtx rb-tree contains less packets, SACK is cheaper.
8) Removal of legacy code. Less maintenance hassles.
Note that I have left the sendpage/zerocopy paths, but they probably can benefit from the same strategy.
Thanks to Oleksandr Natalenko for reporting a performance issue for BBR/fq_codel, which was the main reason I worked on this patch series.
Eric Dumazet (6):
tcp: switch to GSO being always on
tcp: remove sk_can_gso() use
tcp: remove sk_check_csum_caps()
tcp: tcp_sendmsg() only deals with CHECKSUM_PARTIAL
tcp: remove dead code from tcp_set_skb_tso_segs()
tcp: remove dead code after CHECKSUM_PARTIAL adoption
include/net/sock.h | 10 +------- net/core/sock.c | 2 +- net/ipv4/tcp.c | 57 ++++++++++++------------------------------- net/ipv4/tcp_input.c | 3 --- net/ipv4/tcp_ipv4.c | 13 +++------- net/ipv4/tcp_output.c | 40 +++++------------------------- 6 files changed, 26 insertions(+), 99 deletions(-)
Signature · 1 line
2.16.1.291.g4437f3f132-goog