Skip to content

vl: introduce vm_shutdown()

Stefan Hajnoczi qemu-devel 3 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesApplied
  2. v24 patches 4 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

* Rebase on qemu.git/master after AIO_WAIT_WHILE() was merged [Fam]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4block: add aio_wait_bh_oneshot()include/block/aio-wait.h util/aio-wait.c+44 -00 replies
2/4virtio-blk: fix race between .ioeventfd_stop() and vq handlerhw/block/dataplane/virtio-blk.c+17 -70 replies
3/4virtio-scsi: fix race between .ioeventfd_stop() and vq handlerhw/scsi/virtio-scsi-dataplane.c+5 -40 replies
4/4vl: introduce vm_shutdown()cpus.c include/sysemu/iothread.h include/sysemu/sysemu.h +2 more+17 -450 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPaolo BonziniFam ZhengMichael S. Tsirkin
SeriesA-b A-b R-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] vl: introduce vm_shutdown()

v3:
* Rebase on qemu.git/master after AIO_WAIT_WHILE() was merged [Fam]
v2:
* Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd from a BH in the IOThread [Fam]

There are several race conditions in virtio-blk/virtio-scsi dataplane code. This patch series addresses them, see the commit description for details on the individual cases.

Stefan Hajnoczi (4):
block: add aio_wait_bh_oneshot()
virtio-blk: fix race between .ioeventfd_stop() and vq handler
virtio-scsi: fix race between .ioeventfd_stop() and vq handler
vl: introduce vm_shutdown()

 include/block/aio-wait.h        | 13 +++++++++++++
 include/sysemu/iothread.h       |  1 -
 include/sysemu/sysemu.h         |  1 +
 cpus.c                          | 16 +++++++++++++---
 hw/block/dataplane/virtio-blk.c | 24 +++++++++++++++++-------
 hw/scsi/virtio-scsi-dataplane.c |  9 +++++----
 iothread.c                      | 31 -------------------------------
 util/aio-wait.c                 | 31 +++++++++++++++++++++++++++++++
 vl.c                            | 13 +++----------
 9 files changed, 83 insertions(+), 56 deletions(-)
Signature · 1 line
2.14.3