nfs-utils: Use -Werror warning flags to clean up the code.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | configure.ac: clean upconfigure.ac | +6 | 0 replies | |
| 2/7 | Removed missing-prototypes warnings.configure.ac support/ support/ +24 more | +46 | 0 replies | |
| 3/7 | Removed format-overflow=2 warningsconfigure.ac support/ utils/ | +3 | 0 replies | |
| 4/7 | Removed format=2 warningsconfigure.ac utils/ utils/ | +5 | 0 replies | |
| 5/7 | Removed undef warningsconfigure.ac utils/ | +4 | 0 replies | |
| 6/7 | Removed missing-include-dirs warningsconfigure.ac support/ utils/ +2 more | +14 | 0 replies | |
| 7/7 | Added more -Werror= warning flagsconfigure.ac | +13 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] nfs-utils: Use -Werror warning flags to clean up the code.
I received a patch that tried to turns on some of these -Werror flags but could not get passed the warning that were being generated by the rpcgen code.
After taking care of the rpcgen warnings, I took over the patch and finished it off.
The warning flags I choose to use are pattern after the list in the libostree and the systemd list.
Steve Dickson (7):
configure.ac: clean up
Removed missing-prototypes warnings. Removed format-overflow=2 warnings Removed format=2 warnings
Removed undef warnings
Removed missing-include-dirs warnings Added more -Werror= warning flags
configure.ac | 41 ++++++++++++++++++++++++-------------- support/misc/mountpoint.c | 1 + support/nfs/atomicio.c | 2 ++ support/nfs/cacheio.c | 2 +- support/nfs/closeall.c | 2 ++ support/nfs/rpcmisc.c | 1 + support/nfs/strlcat.c | 2 ++ support/nfs/strlcpy.c | 2 ++ support/nfs/svc_socket.c | 2 ++ support/nfs/wildmat.c | 7 +++++++ support/nfsidmap/libnfsidmap.c | 3 ++- support/nfsidmap/nfsidmap_plugin.h | 1 + support/nfsidmap/nss.c | 2 +- systemd/systemd.c | 1 + utils/blkmapd/device-discovery.c | 10 +++++----- utils/blkmapd/dm-device.c | 2 +- utils/gssd/Makefile.am | 2 ++ utils/gssd/err_util.c | 1 + utils/gssd/gss_names.c | 1 + utils/gssd/gssd_proc.c | 4 ++-- utils/gssd/krb5_util.c | 6 +++--- utils/gssd/svcgssd.c | 4 ++-- utils/gssd/svcgssd_mech2file.c | 1 + utils/idmapd/Makefile.am | 2 ++ utils/idmapd/idmapd.c | 4 ++-- utils/mount/configfile.c | 4 ++++ utils/mount/mount_libmount.c | 2 ++ utils/mount/stropts.c | 2 ++ utils/mountd/svc_run.c | 1 + utils/nfsdcltrack/sqlite.c | 3 ++- utils/nfsidmap/Makefile.am | 2 ++ utils/nfsstat/nfsstat.c | 4 +++- utils/statd/svc_run.c | 1 + 33 files changed, 90 insertions(+), 35 deletions(-)
Signature · 1 line
2.14.3