Skip to content

RFC ui: add generic keyboard state tracker, fix keymap

Gerd Hoffmann qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest8 patches 2 repliesIn review
  2. v2 RFC7 patches 12 repliesSuperseded
  3. v1 RFC5 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- s/kbd/qkbd/ to avoid collisons.
- add api docs.
- misc minor fixes.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8kbd-state: add keyboard state trackerinclude/ui/kbd-state.h ui/Makefile.objs ui/kbd-state.c+222 -11 reply
2/8sdl2: remove sdl2_reset_keys() functioninclude/ui/sdl2.h ui/sdl2-input.c+0 -170 replies
3/8kbd-state: use state tracker for sdl2include/ui/sdl2.h ui/sdl2-input.c ui/sdl2.c+7 -340 replies
4/8sdl2: use only QKeyCode in sdl2_process_key()ui/sdl2-input.c+3 -40 replies
5/8kbd-state: use state tracker for gtkinclude/ui/gtk.h ui/gtk.c+8 -320 replies
6/8kbd-state: use state tracker for vncui/vnc.c ui/vnc.h+35 -901 reply
7/8keymap: pass full keyboard state to keysym2scancodeui/curses.c ui/keymaps.c ui/keymaps.h +1 more+8 -100 replies
8/8keymap: fix keyup mappingsui/curses.c ui/keymaps.c ui/keymaps.h +1 more+37 -240 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/8R-b
2/8
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [RFC PATCH v3 0/8] ui: add generic keyboard state tracker, fix keymap

v3:
- s/kbd/qkbd/ to avoid collisons.
- add api docs.
- misc minor fixes.

Gerd Hoffmann (8):
kbd-state: add keyboard state tracker
sdl2: remove sdl2_reset_keys() function
kbd-state: use state tracker for sdl2
sdl2: use only QKeyCode in sdl2_process_key()
kbd-state: use state tracker for gtk
kbd-state: use state tracker for vnc
keymap: pass full keyboard state to keysym2scancode
keymap: fix keyup mappings

 include/ui/gtk.h       |   2 +
 include/ui/kbd-state.h |  96 +++++++++++++++++++++++++++++++++++++
 include/ui/sdl2.h      |   3 +-
 ui/keymaps.h           |   3 +-
 ui/vnc.h               |   5 +-
 ui/curses.c            |   2 +-
 ui/gtk.c               |  38 +++------------
 ui/kbd-state.c         | 125 +++++++++++++++++++++++++++++++++++++++++++++++++
 ui/keymaps.c           |  55 +++++++++++++---------
 ui/sdl2-input.c        |  50 ++------------------
 ui/sdl2.c              |  12 ++---
 ui/vnc.c               | 119 ++++++++++++----------------------------------
 ui/Makefile.objs       |   2 +-
 13 files changed, 310 insertions(+), 202 deletions(-)
 create mode 100644 include/ui/kbd-state.h
 create mode 100644 ui/kbd-state.c
Signature · 1 line
2.9.3