leds: Add driver for NCP5623 3-channel I2C LED driver
Get series with b4
b4 am [email protected]Versions newest first
- v4 Latest2 patches 4 repliesIn review
Changes in v4 from the cover letter
- Rebased on Linux 4.15
- Moved ncp5623_of_match[] after probe
- Fixed computation of max_brightness
- Some more simplifications
- Updated copyright and SPDX license
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | leds: ncp5623: Add device tree binding documentationDocumentation/ | +60 | 2 replies | |
| 2/2 | leds: Add driver for NCP5623 3-channel I2C LED driverdrivers/ drivers/ drivers/ | +240 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Rob Herring | Pavel Machek |
|---|---|---|
| 1/2 | A-b | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver
Hello Jacek and Pavel,
Winter came, then spring, summer and automn went away. Snow came again, and now here is the v4 of the NCP5623 patch... Never too late!
This series add a new driver for On Semiconductor NCP5623, a 3-channel I2C LED driver. It is used in our design to drive a RGB LED.
The first patch introduces the device tree binding, while the second patch adds the driver itself.
Best regards,
Florian
---
v3 -> v4:
- Rebased on Linux 4.15
- Moved ncp5623_of_match[] after probe
- Fixed computation of max_brightness
- Some more simplifications
- Updated copyright and SPDX license
v2 -> v3:
- Rebased on latest leds/for-next
- Minor fixes to the binding documentation
- Removed ncp5623_set_pwm() by inlining it directly inside the caller
- Removed ncp5623_destroy_devices() as we are already using devm_ flavours
- Got rid of the 'active' state variable by using 'led_no' instead
- Some other cosmetic fixes
v1 -> v2:
- Adapted the DT binding (led-max-microamp for each LED node)
- Removed underscores from node names in the example
- Use brightness_set_blocking to avoid workqueue
- Introduced LED_to_CMD macro to avoid switch statement
- Various other fixes
Florian Vaussard (2):
leds: ncp5623: Add device tree binding documentation
leds: Add driver for NCP5623 3-channel I2C LED driver
.../devicetree/bindings/leds/leds-ncp5623.txt | 60 ++++++ drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-ncp5623.c | 228 +++++++++++++++++++++ 4 files changed, 300 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-ncp5623.txt create mode 100644 drivers/leds/leds-ncp5623.c
Signature · 1 line
2.13.6