Skip to content

log level control enhancements

Stephen Hemminger dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v2 posting 2/25 patches 3 repliesSuperseded
  3. v2 posting 1/23 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5eal: make syslog facility table constlib/librte_eal/common/eal_common_options.c+1 -10 replies
2/5eal: allow symbolic log levelslib/librte_eal/common/eal_common_options.c+50 -170 replies
3/5eal: make eal_log_level save privatelib/librte_eal/common/eal_common_log.c lib/librte_eal/common/eal_common_options.c lib/librte_eal/common/eal_private.h +1 more+49 -590 replies
4/5log: add ability to match dynamic log based on shell patterndoc/guides/contributing/coding_style.rst doc/guides/nics/qede.rst lib/librte_eal/common/eal_common_log.c +4 more+114 -362 replies
5/5doc: update guides for current preferrred log level syntaxdoc/guides/cryptodevs/dpaa2_sec.rst doc/guides/cryptodevs/dpaa_sec.rst doc/guides/faq/faq.rst +4 more+22 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] log level control enhancements

This patch set improves the log-level option in EAL. It adds symbolic names for log levels (error, info, debug, etc) and shell style matching of log levels.
--log-level='pmd.ixgbe.*:debug'

The original syntax (which is maintained for compatibility) used numeric values, comma as separator and regular expression to match log level.

It was often documented as:
--log-level='pmd.ixgbe.*,8' ...
but this only worked by accident. The period was really a regular expression match any character (not match a period); and the asterisk in regular expression is match repeated value.

v3
- rename internal function rte_eal_log_save_XXX to rte_log_save_XXX
- fixup typos in coding style doc

v2
- make facility table constant
- rebase to include support for dynamic log late binding
- add patch to make saving log level a private API
- update driver docs

Stephen Hemminger (5):
eal: make syslog facility table const
eal: allow symbolic log levels
eal: make eal_log_level save private
log: add ability to match dynamic log based on shell pattern
doc: update guides for current preferrred log level syntax

 doc/guides/contributing/coding_style.rst   |   4 +-
 doc/guides/cryptodevs/dpaa2_sec.rst        |   2 +-
 doc/guides/cryptodevs/dpaa_sec.rst         |   2 +-
 doc/guides/faq/faq.rst                     |  23 ++---
 doc/guides/nics/dpaa2.rst                  |   4 +-
 doc/guides/nics/qede.rst                   |   2 +-
 doc/guides/nics/sfc_efx.rst                |  12 +--
 doc/guides/nics/tap.rst                    |   2 +-
 lib/librte_eal/common/eal_common_log.c     | 103 ++++++++++++++++---
 lib/librte_eal/common/eal_common_options.c | 113 +++++++++++++--------
 lib/librte_eal/common/eal_private.h        |   6 ++
 lib/librte_eal/common/include/rte_log.h    |  44 +++-----
 lib/librte_eal/rte_eal_version.map         |   7 ++
 13 files changed, 211 insertions(+), 113 deletions(-)
Signature · 1 line
2.17.0