Skip to content

mm: improve zone->lock scalability

Aaron Lu linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 35 repliesIn review
  2. v33 patches 6 repliesSuperseded

Changes in v4 from the cover letter

Address David Rientjes' comments to not update pcp->count in front of free_pcppages_bulk() in patch 1/3.
Reword code comments in patch 2/3 as suggested by David Rientjes.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mm/free_pcppages_bulk: update pcp->count insidemm/page_alloc.c+3 -74 replies
2/3mm/free_pcppages_bulk: do not hold lock when picking pages to freemm/page_alloc.c+23 -1612 replies
3/3mm/free_pcppages_bulk: prefetch buddy while not holding lockmm/page_alloc.c+15 -012 replies
3/3mm/free_pcppages_bulk: prefetch buddy while not holding lockmm/page_alloc.c+20 -17 replies
3/3mm/free_pcppages_bulk: prefetch buddy while not holding lockmm/page_alloc.c+22 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMel GormanDavid RientjesMichal HockoAndrew MortonVlastimil Babka
1/3A-b A-b A-b
2/3A-b A-b
3/3R-b R-b A-b A-b
3/3R-b R-b A-b A-b
3/3R-b R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] mm: improve zone->lock scalability

Patch 1/3 is a small cleanup suggested by Matthew Wilcox which doesn't affect scalability or performance;
Patch 2/3 moves some code in free_pcppages_bulk() outside of zone->lock and has Mel Gorman's ack;
Patch 3/3 uses prefetch in free_pcppages_bulk() outside of zone->lock to speedup page merging under zone->lock but Mel Gorman has some concerns.

For details, please see their changelogs.

v4:
Address David Rientjes' comments to not update pcp->count in front of free_pcppages_bulk() in patch 1/3.
Reword code comments in patch 2/3 as suggested by David Rientjes.

v3:
Added patch 1/3 to update pcp->count inside of free_pcppages_bulk(); Rebase to v4.16-rc2.

v2 & v1:
https://lkml.org/lkml/2018/1/23/879

Aaron Lu (3):
mm/free_pcppages_bulk: update pcp->count inside mm/free_pcppages_bulk: do not hold lock when picking pages to free mm/free_pcppages_bulk: prefetch buddy while not holding lock

 mm/page_alloc.c | 62 +++++++++++++++++++++++++++++++++++++--------------------
 1 file changed, 40 insertions(+), 22 deletions(-)
Signature · 7 lines
2.14.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>