Skip to content

PCI: armada8k: Fix clock resource for Armada 7K/8K

Gregory CLEMENT linux-arm-kernel linux-pci 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Removed a unneeded new line in the binding documentation, pointed by Thomas Petazzoni.

- Added a new line in driver code, pointed by Thomas Petazzoni.

- Managed the failure of clk_prepare_enable for the clk_reg in a separate case, pointed by Thomas Petazzoni.

- Simplified the -EPROBE_DEFER case for the clk_reg, suggested by Russell King

- Added backed the line getting the reg clock that disappeared in the first version.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: armada8k: Remove useless test before clk_disable_unpreparedrivers/pci/dwc/pcie-armada8k.c+1 -20 replies
2/2PCI: armada8k: Fix clock resource by adding a register clockDocumentation/devicetree/bindings/pci/pci-armada8k.txt drivers/pci/dwc/pcie-armada8k.c+20 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] PCI: armada8k: Fix clock resource for Armada 7K/8K

Hi,

This short series fixes the way the clocks are used for the PCIe host controller embedded in the Marvell Armada 7K/8K SoCs. On these SoCs a second one is needed in order to clock the registers. It was not noticed until now because we relied on the bootloader and also because the clock driver was wrong.

Thanks to this fix, it would be possible to fix the clock driver without introducing a regression.

The first patch is just a small cleanup found when I wrote the main patch.

Changelog:
v1 -> v2:

- Removed a unneeded new line in the binding documentation, pointed by Thomas Petazzoni.

- Added a new line in driver code, pointed by Thomas Petazzoni.

- Managed the failure of clk_prepare_enable for the clk_reg in a separate case, pointed by Thomas Petazzoni.

- Simplified the -EPROBE_DEFER case for the clk_reg, suggested by Russell King

- Added backed the line getting the reg clock that disappeared in the first version.

Gregory CLEMENT (2):
PCI: armada8k: Remove useless test before clk_disable_unprepare
PCI: armada8k: Fix clock resource by adding a register clock

 .../devicetree/bindings/pci/pci-armada8k.txt        |  5 ++++-
 drivers/pci/dwc/pcie-armada8k.c                     | 21 +++++++++++++++++----
 2 files changed, 21 insertions(+), 5 deletions(-)
Signature · 1 line
2.16.1