Skip to content

iomap: Use FUA for O_DSYNC DIO writes

Dave Chinner linux-block linux-fsdevel linux-xfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v2 posting 2/24 patches 14 repliesApplied
  3. v2 posting 1/23 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC1 patch27 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: move generic_write_sync calls inwardsfs/xfs/xfs_file.c+33 -150 replies
2/3iomap: iomap_dio_rw() handles all sync writesfs/iomap.c fs/xfs/xfs_file.c+15 -110 replies
3/3iomap: Use FUA for pure data O_DSYNC DIO writesfs/iomap.c+46 -50 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph HellwigDarrick J. Wong
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH 0/3 v3] iomap: Use FUA for O_DSYNC DIO writes

Hi folks,

Version 3 of the FUA for O-DSYNC patchset. This version fixes bugs found in the previous version. Functionality is otherwise the same as described in the first version:

https://marc.info/?l=linux-xfs&m=152213446528167&w=2

Version 3:

- fixed O_SYNC behaviour as noticed by Jan Kara
- fixed use after free on IO completion due iomap_dio_complete_work() simplification added in version 2. Found by KASAN when running xfstests.

Version 2:
- Fixed comment typos in first patch
- simplified iomap_dio_complete_work()
- changed IOMAP_DIO_WRITE_SYNC to IOMAP_DIO_NEED_SYNC
- split blk_queue_fua() into it's own patch
- fixed formatting issue in last patch
- update bio->io_opf directly rather than use bio_set_op_attrs()
- Updated comment to mention we try to use FUA optimistically.