Skip to content

FOLL_NOWAIT and get_user_pages_unlocked

Andrea Arcangeli linux-mm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1mm: gup: teach get_user_pages_unlocked to handle FOLL_NOWAITmm/gup.c+5 -21 reply

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by.

PatchDr. David Alan Gilbert
1/1T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] FOLL_NOWAIT and get_user_pages_unlocked

Hello,

KVM is hanging on postcopy live migration.

David tracked it down to commit ce53053ce378c21e7ffc45241fd67d6ee79daa2b and the problem is pretty obvious then.

Either we teach get_user_pages_locked/unlocked to handle FOLL_NOWAIT (so faultin_nopage works right even when the nonblocking pointer is not NULL) or we need to revert part of commit ce53053ce378c21e7ffc45241fd67d6ee79daa2b and keep using FOLL_NOWAIT only as parameter to get_user_pages (which won't ever set nonblocking pointer to non-NULL). I suppose the former approach is preferred to be more robust.

Thanks,
Andrea

Andrea Arcangeli (1):
mm: gup: teach get_user_pages_unlocked to handle FOLL_NOWAIT

 mm/gup.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>