Skip to content

btrfs-progs: qgroups-usability

[email protected] linux-btrfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 1 replyIn review
  2. v220 patches 10 repliesSuperseded
  3. v18 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- Updated Reviewed-by tags were provided.
- Fixed the typoed commands that I commented on in the previous posting.
- Dropped the btrfs_cleanup_root_info since it's unnecessary with the switch to libbtrfsutil.
- Updated the qgroups pathname patch to use libbtrfsutil
- Added a mini-filter to skip dead qgroups in 'qgroup show' output unless -v is specified.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18btrfs-progs: quota: Add -W option to rescan to wait without starting rescanDocumentation/btrfs-quota.asciidoc cmds-quota.c+21 -90 replies
2/18btrfs-progs: qgroups: fix misleading index checkqgroup.c+1 -10 replies
3/18btrfs-progs: constify pathnames passed as argumentschunk-recover.c cmds-device.c cmds-fi-usage.c +1 more+8 -80 replies
4/18btrfs-progs: btrfs-list: add rb_entry helpers for root_infobtrfs-list.c+20 -100 replies
5/18btrfs-progs: qgroups: add pathname to show outputDocumentation/btrfs-qgroup.asciidoc cmds-qgroup.c kerncompat.h +2 more+157 -191 reply
6/18btrfs-progs: qgroups: introduce and use info and limit structuresqgroup.c qgroup.h+52 -380 replies
7/18btrfs-progs: qgroups: introduce btrfs_qgroup_queryqgroup.c qgroup.h+116 -340 replies
8/18btrfs-progs: subvolume: add quota info to btrfs sub showcmds-subvolume.c+50 -10 replies
9/18btrfs-progs: help: convert ints used as bools to boolbtrfs.c help.c help.h+22 -210 replies
10/18btrfs-progs: reorder placement of help declarations for send/receivecmds-receive.c cmds-send.c+66 -650 replies
11/18btrfs-progs: filesystem balance: split out special handlingcmds-filesystem.c+15 -20 replies
12/18btrfs-progs: use cmd_struct as command entry pointbtrfs.c check/main.c cmds-balance.c +20 more+317 -2370 replies
13/18btrfs-progs: pass cmd_struct to command callback functionbtrfs.c check/main.c cmds-balance.c +19 more+146 -980 replies
14/18btrfs-progs: pass cmd_struct to clean_args_no_options{,_relaxed}cmds-balance.c cmds-device.c cmds-filesystem.c +8 more+46 -410 replies
15/18btrfs-progs: pass cmd_struct to usage()check/main.c cmds-balance.c cmds-device.c +19 more+115 -1250 replies
16/18btrfs-progs: add support for output formatsbtrfs.c check/main.c cmds-balance.c +21 more+299 -830 replies
17/18btrfs-progs: handle command groups directly for common casebtrfs.c cmds-balance.c cmds-device.c +10 more+14 -660 replies
18/18btrfs-progs: qgroups: don't print dead qgroupsqgroup.c+9 -10 replies

Reviews trailers per patch

7 of 18 patches have a Reviewed-by or Acked-by.

PatchQu WenruoNikolay Borisov
1/18R-b
2/18R-b R-b
3/18R-b
4/18
5/18R-b
6/18R-b
7/18R-b
8/18
9/18R-b
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/18] btrfs-progs: qgroups-usability

From: Jeff Mahoney <[email protected]>

Changes since v2:
- Updated Reviewed-by tags were provided.
- Fixed the typoed commands that I commented on in the previous posting.
- Dropped the btrfs_cleanup_root_info since it's unnecessary with the switch to libbtrfsutil.
- Updated the qgroups pathname patch to use libbtrfsutil
- Added a mini-filter to skip dead qgroups in 'qgroup show' output unless -v is specified.

The most notable change is that this posting doesn't include the JSON format patches since there was still some open discussion there. The plumbing for passing global options around to commands is there, so we really just need to decide on how we want to handle alternative formats. For some commands, the formatting library that coreutils uses will probably work but for qgroups show to represent nested groups, it's unsuitable.

I've also posted this as a pull request to the devel branch:

https://github.com/kdave/btrfs-progs/pull/139

Jeff Mahoney (18):
btrfs-progs: quota: Add -W option to rescan to wait without starting
rescan
btrfs-progs: qgroups: fix misleading index check
btrfs-progs: constify pathnames passed as arguments
btrfs-progs: btrfs-list: add rb_entry helpers for root_info
btrfs-progs: qgroups: add pathname to show output
btrfs-progs: qgroups: introduce and use info and limit structures
btrfs-progs: qgroups: introduce btrfs_qgroup_query
btrfs-progs: subvolume: add quota info to btrfs sub show
btrfs-progs: help: convert ints used as bools to bool
btrfs-progs: reorder placement of help declarations for send/receive
btrfs-progs: filesystem balance: split out special handling
btrfs-progs: use cmd_struct as command entry point
btrfs-progs: pass cmd_struct to command callback function
btrfs-progs: pass cmd_struct to clean_args_no_options{,_relaxed}
btrfs-progs: pass cmd_struct to usage()
btrfs-progs: add support for output formats
btrfs-progs: handle command groups directly for common case
btrfs-progs: qgroups: don't print dead qgroups

 Documentation/btrfs-qgroup.asciidoc |   4 +
 Documentation/btrfs-quota.asciidoc  |  10 +-
 btrfs-list.c                        |  30 ++-
 btrfs.c                             | 174 +++++++++++-----
 check/main.c                        |  10 +-
 chunk-recover.c                     |   4 +-
 cmds-balance.c                      |  74 ++++---
 cmds-device.c                       |  96 +++++----
 cmds-fi-du.c                        |  11 +-
 cmds-fi-usage.c                     |  17 +-
 cmds-filesystem.c                   | 113 +++++++----
 cmds-inspect-dump-super.c           |  11 +-
 cmds-inspect-dump-tree.c            |  11 +-
 cmds-inspect-tree-stats.c           |  11 +-
 cmds-inspect.c                      |  78 ++++----
 cmds-property.c                     |  55 +++---
 cmds-qgroup.c                       | 107 ++++++----
 cmds-quota.c                        |  63 +++---
 cmds-receive.c                      |  70 +++----
 cmds-replace.c                      |  45 +++--
 cmds-rescue.c                       |  60 +++---
 cmds-restore.c                      |  12 +-
 cmds-scrub.c                        |  64 +++---
 cmds-send.c                         |  74 +++----
 cmds-subvolume.c                    | 163 ++++++++++-----
 commands.h                          | 152 ++++++++------
 help.c                              |  98 ++++++---
 help.h                              |  14 +-
 kerncompat.h                        |   1 +
 qgroup.c                            | 384 +++++++++++++++++++++++++++---------
 qgroup.h                            |  19 +-
 31 files changed, 1325 insertions(+), 710 deletions(-)
Signature · 1 line
2.15.1