Skip to content

ext4 encryption fixes for 4.1-stable

Eric Biggers linux-ext4 stable 1 version Applied

Status from this message: Applied, thank you!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3ext4: require encryption feature for EXT4_IOC_SET_ENCRYPTION_POLICYfs/ext4/ioctl.c+3 -00 replies
2/3fscrypto: add authorization check for setting encryption policyfs/ext4/crypto_policy.c+3 -00 replies
3/3ext4 crypto: don't regenerate the per-inode encryption key unnecessarilyfs/ext4/crypto_fname.c fs/ext4/crypto_key.c fs/ext4/ext4.h +1 more+19 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 4.1 0/3] ext4 encryption fixes for 4.1-stable

From: Eric Biggers <[email protected]>

Hi Sasha, can you please apply these backports of ext4 encryption fixes to 4.1-stable? They all have equivalent fixes in 4.4-stable. Most important is patch 1 which prevents unprivileged users from using (or abusing) ext4 encryption when it hasn't been enabled on the filesystem by a system administrator. Patch 2 adds a missing permission check (CVE-2016-10318), and patch 3 is a backport that Ted sent out some months ago that seems to have been missed, for a bug in 4.1 that is very similar to the bug in 4.2+ that was assigned CVE-2017-7374.

Note that ext4 encryption in 4.1 is still pretty broken and should not be used (even just 4.4-stable is much better); these are just the most important fixes that really ought to be in 4.1-stable.

Eric Biggers (1):
fscrypto: add authorization check for setting encryption policy

Richard Weinberger (1):
ext4: require encryption feature for EXT4_IOC_SET_ENCRYPTION_POLICY

Theodore Ts'o (1):
ext4 crypto: don't regenerate the per-inode encryption key
unnecessarily

 fs/ext4/crypto_fname.c  |  5 +++--
 fs/ext4/crypto_key.c    | 15 ++++++++++++---
 fs/ext4/crypto_policy.c |  3 +++
 fs/ext4/ext4.h          |  1 +
 fs/ext4/ioctl.c         |  3 +++
 fs/ext4/super.c         |  3 +++
 6 files changed, 25 insertions(+), 5 deletions(-)
Signature · 1 line
2.16.2.395.g2e18187dfd-goog