Skip to content

Add support for unmanaged SR-IOV

Alexander Duyck kvm linux-nvme linux-pci lkml netdev virtio-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 4 repliesIn review
  2. v33 patches 2 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pci-iov: Add support for unmanaged SR-IOVDocumentation/ABI/testing/sysfs-bus-pci drivers/pci/iov.c drivers/pci/pci-driver.c +3 more+101 -24 replies
2/4virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devicesdrivers/virtio/virtio_pci_common.c+3 -00 replies
3/4ena: Migrate over to "unmanaged SR-IOV" supportdrivers/net/ethernet/amazon/ena/ena_netdev.c+3 -270 replies
4/4nvme: Migrate over to "unmanaged SR-IOV" supportdrivers/nvme/host/pci.c+3 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [pci PATCH v4 0/4] Add support for unmanaged SR-IOV

This series is meant to add support for SR-IOV on devices when the VFs are not managed by the kernel. Examples of recent patches attempting to do this include:
virto - https://patchwork.kernel.org/patch/10241225/
pci-stub - https://patchwork.kernel.org/patch/10109935/
vfio - https://patchwork.kernel.org/patch/10103353/
uio - https://patchwork.kernel.org/patch/9974031/

Since this is quickly blowing up into a multi-driver problem it is probably best to implement this solution as generically as possible.

This series is an attempt to do that. What we do with this patch set is provide a generic framework to enable SR-IOV in the case that the PF driver doesn't support managing the VFs itself.

I based my patch set originally on the patch by Mark Rustad but there isn't much left after going through and cleaning out the bits that were no longer needed, and after incorporating the feedback from David Miller. At this point the only items to be fully reused was his patch description which is now present in patch 3 of the set.

This solution is limited in scope to just adding support for devices that provide no functionality for SR-IOV other than allocating the VFs by calling pci_enable_sriov. Previous sets had included patches for VFIO, but for now I am dropping that as the scope of that work is larger then I think I can take on at this time.

v2: Reduced scope back to just virtio_pci and vfio-pci
Broke into 3 patch set from single patch
Changed autoprobe behavior to always set when num_vfs is set non-zero
v3: Updated Documentation to clarify when sriov_unmanaged_autoprobe is used
Wrapped vfio_pci_sriov_configure to fix build errors w/o SR-IOV in kernel
v4: Dropped vfio-pci patch
Added ena and nvme to drivers now using pci_sriov_configure_unmanaged Dropped pci_disable_sriov call in virtio_pci to be consistent with ena

Cc Mark Rustad <[email protected]>
Cc Maximilian Heyne <[email protected]>
Cc Liang-Min Wang <[email protected]>
Cc David Woodhouse <[email protected]>

---

Alexander Duyck (4):
pci-iov: Add support for unmanaged SR-IOV
virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices
ena: Migrate over to "unmanaged SR-IOV" support
nvme: Migrate over to "unmanaged SR-IOV" support

 Documentation/ABI/testing/sysfs-bus-pci      |   25 +++++++++++++++
 drivers/net/ethernet/amazon/ena/ena_netdev.c |   30 ++-----------------
 drivers/nvme/host/pci.c                      |   22 ++------------
 drivers/pci/iov.c                            |   42 ++++++++++++++++++++++++++
 drivers/pci/pci-driver.c                     |    2 +
 drivers/pci/pci-sysfs.c                      |   29 ++++++++++++++++++
 drivers/pci/pci.h                            |    4 ++
 drivers/virtio/virtio_pci_common.c           |    3 ++
 include/linux/pci.h                          |    1 +
 9 files changed, 110 insertions(+), 48 deletions(-)

--