nd/parseopt-completion fixups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 0 repliesNew
- v12 patches 7 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | completion: don't set PARSE_OPT_NOCOMPLETE on --rerere-autoupdatecontrib/ parse-options.h rerere.h | +5 | 0 replies | |
| 2/4 | completion: simplify _git_notescontrib/ | +3 | 0 replies | |
| 3/4 | completion: complete --{reuse,reedit}-message= for all notes subcmdscontrib/ | +1 | 0 replies | |
| 4/4 | completion: more subcommands in _git_notes()contrib/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/4] nd/parseopt-completion fixups
v2 fixes the comments from v1 and adds to new patches to improve _git_notes() (sorry I couldn't resist)
Interdiff with what's on 'pu'
contrib/completion/git-completion.bash +6 -8
@@ -1815,7 +1815,7 @@ _git_name_rev () _git_notes () { - local subcommands='add append copy edit list prune remove show' + local subcommands='add append copy edit get-ref list merge prune remove show' local subcommand="$(__git_find_on_cmdline "$subcommands")" case "$subcommand,$cur" in
@@ -1832,18 +1832,15 @@ _git_notes () ;; esac ;; - add,--reuse-message=*|append,--reuse-message=*|\ - add,--reedit-message=*|append,--reedit-message=*) + *,--reuse-message=*|*,--reedit-message=*) __git_complete_refs --cur="${cur#*=}" ;; - prune,--*) - __gitcomp_builtin notes_prune - ;; - prune,*) - ;; *,--*) __gitcomp_builtin notes_$subcommand ;; + prune,*|get-ref,*) + # this command does not take a ref, do not complete it + ;; *) case "$prev" in -m|-F)
@@ -1956,6 +1953,7 @@ _git_rebase () --autostash --no-autostash --verify --no-verify --keep-empty --root --force-rebase --no-ff + --rerere-autoupdate --exec "
Nguyễn Thái Ngọc Duy (4):
completion: don't set PARSE_OPT_NOCOMPLETE on --rerere-autoupdate
completion: simplify _git_notes
completion: complete --{reuse,reedit}-message= for all notes subcmds
completion: more subcommands in _git_notes()
contrib/completion/git-completion.bash | 25 ++++++++----------------- parse-options.h | 4 ++-- rerere.h | 3 +-- 3 files changed, 11 insertions(+), 21 deletions(-)
Signature · 1 line
2.16.2.785.g429c04a1b9