Make cvs tests pass with '-x' tracing and /bin/sh
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | t9400-git-cvsserver-server: don't rely on the output of 'test_cmp't/ | +9 | 5 replies | |
| 1/2 | t9400-git-cvsserver-server: don't rely on the output of 'test_cmp't/ | +3 | 4 replies | |
| 2/2 | t9402-git-cvsserver-refs: don't check the stderr of a subshellt/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] Make cvs tests pass with '-x' tracing and /bin/sh
Quoted 5 lines · SZEDER Gábor
Quoted 4 lines
This patch series makes '-x' tracing of tests work reliably even when running them with
/bin/sh, and setting TEST_SHELL_PATH=bash will be unnecessary.
Quoted 8 lines
Quoted 4 lines
make GIT_TEST_OPTS='-x --verbose-log' testpasses on my setup and on all Travis CI build jobs (though neither me nor Travis CI run all tests, e.g. CVS).
I installed 'cvs' and whatnot to run t94* and t96* tests, and sure enough, 5 tests in 2 test scripts fail with '-x' tracing and
/bin/sh. I think I will be able to get around to send v2 during the weekend.
Well, I wasn't able to get around to it, and in the meantime 'sg/test-x' got merged into 'next'. So here are the updates for those two test scripts.
The commit message of the first patch is perhaps unnecessary long, but it's mostly about explaining why the affected test was working reasonably well despite the rather weird 'test_cmp this that >>out 2>&1' thing.
SZEDER Gábor (2):
t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'
t9402-git-cvsserver-refs: don't check the stderr of a subshell
t/t9400-git-cvsserver-server.sh | 15 +++++++++------ t/t9402-git-cvsserver-refs.sh | 8 ++++---- 2 files changed, 13 insertions(+), 10 deletions(-)
Signature · 1 line
2.16.2.603.g180c1428f0