luks: Implement .bdrv_co_create
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 6 repliesIn review
- v16 patches 19 repliesSuperseded
Changes in v2 from the cover letter
- Use QCryptoBlockCreateOptionsLUKS as the base type for BlockdevCreateOptionsLUKS [Dan]
- Use INT64_MAX instead of UINT64_MAX as the maximum image size [Eric]
- Use iter_time=10 in tests where the creation succeeds [Dan]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | luks: Separate image file creation from formattingblock/ | +17 | 0 replies | |
| 2/6 | luks: Create block_crypto_co_create_generic()block/ | +61 | 2 replies | |
| 3/6 | luks: Support .bdrv_co_createblock/ qapi/ | +50 | 1 reply | |
| 4/6 | luks: Turn invalid assertion into checkblock/ | +4 | 1 reply | |
| 5/6 | luks: Catch integer overflow for huge sizesblock/ | +5 | 0 replies | |
| 6/6 | qemu-iotests: Test luks QMP image creationtests/ tests/ tests/ +1 more | +348 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Daniel P. Berrangé | Eric Blake |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | |
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/6] luks: Implement .bdrv_co_create
This series implements the .bdrv_co_create callback for luks, adds an image creation test for it and contains some bonus fixes for bugs that the test triggered.
v2:
- Use QCryptoBlockCreateOptionsLUKS as the base type for BlockdevCreateOptionsLUKS [Dan]
- Use INT64_MAX instead of UINT64_MAX as the maximum image size [Eric]
- Use iter_time=10 in tests where the creation succeeds [Dan]
Kevin Wolf (6):
luks: Separate image file creation from formatting
luks: Create block_crypto_co_create_generic()
luks: Support .bdrv_co_create
luks: Turn invalid assertion into check
luks: Catch integer overflow for huge sizes
qemu-iotests: Test luks QMP image creation
qapi/block-core.json | 17 +++- block/crypto.c | 150 ++++++++++++++++++++++--------- tests/qemu-iotests/209 | 210 +++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/209.out | 136 ++++++++++++++++++++++++++++ tests/qemu-iotests/common.rc | 2 +- tests/qemu-iotests/group | 1 + 6 files changed, 472 insertions(+), 44 deletions(-) create mode 100755 tests/qemu-iotests/209 create mode 100644 tests/qemu-iotests/209.out
Signature · 1 line
2.13.6