Skip to content

fstests: GDBM detection cleanup

[email protected] fstests 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4build: remove dead AC_PACKAGE_WANT_NDBM macrom4/package_gdbmdev.m4+0 -200 replies
2/4build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection failsm4/package_gdbmdev.m4+9 -100 replies
3/4build: clean up AC_PACKAGE_WANT_GDBMm4/package_gdbmdev.m4+55 -320 replies
4/4build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBMm4/package_gdbmdev.m4 src/dbtest.c+3 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] fstests: GDBM detection cleanup

From: Jeff Mahoney <[email protected]>

Commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c to build) fixed building on newer SUSE systems but broke older ones. Where we used to skip building src/dbtest on SLES systems, now we'd fail to build on SLES11. The reason was that we were now detecting ndbm.h but also including gdbm.h, which doesn't work on older systems due to both defining the datum type. It turns out that no system needs gdbm.h at all.

This series cleans up the macros and fixes detection for all systems that only have /usr/include/ndbm.h.

-Jeff

---

Jeff Mahoney (4):
build: remove dead AC_PACKAGE_WANT_NDBM macro
build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection
fails
build: clean up AC_PACKAGE_WANT_GDBM
build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBM

 m4/package_gdbmdev.m4 | 104 ++++++++++++++++++++++----------------------------
 src/dbtest.c          |   3 --
 2 files changed, 46 insertions(+), 61 deletions(-)
Signature · 1 line
2.15.1