Skip to content

irqchip/gic*: Complain about the use of IRQ_TYPE_NONE

Marc Zyngier linux-arm-kernel linux-devicetree lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONEdrivers/irqchip/irq-gic.c+5 -00 replies
2/2irqchip/gic-v3: Loudly complain about the use of IRQ_TYPE_NONEdrivers/irqchip/irq-gic-v3.c+5 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] irqchip/gic*: Complain about the use of IRQ_TYPE_NONE

Grepping through the dts files, the documentation, and reviewing patches, one can only notice the use of IRQ_TYPE_NONE in interrupt specifiers. At least for the GIC, this doesn't mean anything. The unsuspecting driver will end-up with whatever was there before, and there is a 50% probability that it is not what it wants.

I'd love to fix it myself, but I also have a 50% probability of getting it wrong. In order to make the user aware they are walking on thin ice, let's add some warnings. Hopefully, they'll be annoying enough that people will fix their firmware. Croudsourcing debugging...

If nobody complains louder than the warnings, I plan to get this into 4.17.

Marc Zyngier (2):
irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE irqchip/gic-v3: Loudly complain about the use of IRQ_TYPE_NONE

 drivers/irqchip/irq-gic-v3.c | 5 +++++
 drivers/irqchip/irq-gic.c    | 5 +++++
 2 files changed, 10 insertions(+)
Signature · 1 line
2.14.2