Add rpi3 b+ support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest0 of 7 patches 0 repliesNew
- v3 posting 2/20 of 7 patches 0 repliesSuperseded
- v3 posting 1/20 of 7 patches 0 repliesSuperseded
Patches in v4 No applies recorded yet
None of the 7 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [Buildroot] [PATCH v4 0/7] Add rpi3 b+ support
Hello Martin,
Quoted 8 lines · Martin Bark
Martin Bark (7):
package/rpi-firmware: bump version configs/raspberrypi*: bump kernel version board/raspberrypi: add support for rpi3 b+ package/rpi-firmware: improve installation of dtb files package/rpi-bt-firmware: change to LibreELEC github repo package/rpi-wifi-firmware: change to LibreELEC github repo
DEVELOPERS: add myself for rpi packages
I've applied the entire series. Two comments:
- Use exactly "---" below your SoB to add the changelog or additional comments. If you don't do this, it doesn't get recognized as a separator, and the changelog becomes part of the commit log.
- Use "foreach" make loops instead of "for" shell loops. It is more Buildroot-ish, and the "foreach" make loops do the error checking automatically at each iteration of the loop. Due to the usage of a "for" shell loop, error checking was missing in the rpi-bt-firmware change you made. There is a remaining "for" shell loop in the rpi-firmware package, it would be good to get rid of it as well.
Thanks a lot for this contribution!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com