Skip to content

eeprom: at24: driver refactoring

Bartosz Golaszewski linux-i2c lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21eeprom: at24: disable regmap lockingdrivers/misc/eeprom/at24.c+1 -00 replies
2/21eeprom: at24: remove nvmem_config from at24_datadrivers/misc/eeprom/at24.c+16 -160 replies
3/21eeprom: at24: arrange local variablesdrivers/misc/eeprom/at24.c+16 -103 replies
4/21eeprom: at24: use SPDX identifier instead of GPL boiler-platedrivers/misc/eeprom/at24.c+2 -56 replies
5/21eeprom: at24: remove code separatorsdrivers/misc/eeprom/at24.c+0 -40 replies
6/21eeprom: at24: drop redundant variable in at24_read()drivers/misc/eeprom/at24.c+6 -80 replies
7/21eeprom: at24: drop redundant variable in at24_write()drivers/misc/eeprom/at24.c+6 -80 replies
8/21eeprom: at24: make struct initialization uniform in at24_probe()drivers/misc/eeprom/at24.c+1 -10 replies
9/21eeprom: at24: don't check if byte_len is a power of 2drivers/misc/eeprom/at24.c+0 -30 replies
10/21eeprom: at24: rename at24_get_pdata()drivers/misc/eeprom/at24.c+3 -20 replies
11/21eeprom: at24: rename chip to pdata in at24_probe()drivers/misc/eeprom/at24.c+21 -210 replies
12/21eeprom: at24: use a helper variable for devdrivers/misc/eeprom/at24.c+23 -250 replies
13/21eeprom: at24: readability tweak in at24_probe()drivers/misc/eeprom/at24.c+3 -20 replies
14/21eeprom: at24: provide and use at24_base_client_dev()drivers/misc/eeprom/at24.c+7 -20 replies
15/21eeprom: at24: switch to using probe_new() from the i2c frameworkdrivers/misc/eeprom/at24.c+5 -20 replies
16/21eeprom: at24: move platform data processing into a separate routinedrivers/misc/eeprom/at24.c+40 -300 replies
17/21eeprom: at24: remove at24_platform_data from at24_datadrivers/misc/eeprom/at24.c+13 -90 replies
18/21eeprom: at24: refactor at24_probe()drivers/misc/eeprom/at24.c+18 -160 replies
19/21eeprom: at24: tweak newlinesdrivers/misc/eeprom/at24.c+1 -10 replies
20/21eeprom: at24: fix a line breakdrivers/misc/eeprom/at24.c+2 -20 replies
21/21eeprom: at24: simplify the i2c functionality checkingdrivers/misc/eeprom/at24.c+7 -50 replies

Reviews trailers per patch

None of the 21 patches has a Reviewed-by or Acked-by.

PatchAndy Shevchenko
SeriesT-b
1/21T-b
2/21T-b
3/21T-b
4/21
5/21T-b
6/21T-b
7/21T-b
8/21T-b
9/21T-b
10/21T-b
11/21T-b
12/21T-b
13/21T-b
14/21T-b
15/21T-b
16/21T-b
17/21T-b
18/21T-b
19/21T-b
20/21T-b
21/21T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/21] eeprom: at24: driver refactoring

This series contains what I hope to be a non-controversial refactoring of the at24 eeprom driver.

Most changes revolve around at24_probe() which became quite complicated and hard to read.

The only functional changes are: disabling the internal locking mechanisms of regmap (since we already take care of that in the driver) and removing an if checking if byte_len is a power of 2 (as we do support models for which it's not true).

All other patches affect readability and code structure.

Tested with a couple models and different both for device tree and platform data modes.

Bartosz Golaszewski (21):
eeprom: at24: disable regmap locking
eeprom: at24: remove nvmem_config from at24_data
eeprom: at24: arrange local variables
eeprom: at24: use SPDX identifier instead of GPL boiler-plate
eeprom: at24: remove code separators
eeprom: at24: drop redundant variable in at24_read()
eeprom: at24: drop redundant variable in at24_write()
eeprom: at24: make struct initialization uniform in at24_probe()
eeprom: at24: don't check if byte_len is a power of 2
eeprom: at24: rename at24_get_pdata()
eeprom: at24: rename chip to pdata in at24_probe()
eeprom: at24: use a helper variable for dev
eeprom: at24: readability tweak in at24_probe()
eeprom: at24: provide and use at24_base_client_dev()
eeprom: at24: switch to using probe_new() from the i2c framework
eeprom: at24: move platform data processing into a separate routine
eeprom: at24: remove at24_platform_data from at24_data
eeprom: at24: refactor at24_probe()
eeprom: at24: tweak newlines
eeprom: at24: fix a line break
eeprom: at24: simplify the i2c functionality checking

 drivers/misc/eeprom/at24.c | 293 ++++++++++++++++++++++++---------------------
 1 file changed, 156 insertions(+), 137 deletions(-)
Signature · 1 line
2.16.1