eeprom: at24: driver refactoring
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest21 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | eeprom: at24: disable regmap lockingdrivers/ | +1 | 0 replies | |
| 2/21 | eeprom: at24: remove nvmem_config from at24_datadrivers/ | +16 | 0 replies | |
| 3/21 | eeprom: at24: arrange local variablesdrivers/ | +16 | 3 replies | |
| 4/21 | eeprom: at24: use SPDX identifier instead of GPL boiler-platedrivers/ | +2 | 6 replies | |
| 5/21 | eeprom: at24: remove code separatorsdrivers/ | +0 | 0 replies | |
| 6/21 | eeprom: at24: drop redundant variable in at24_read()drivers/ | +6 | 0 replies | |
| 7/21 | eeprom: at24: drop redundant variable in at24_write()drivers/ | +6 | 0 replies | |
| 8/21 | eeprom: at24: make struct initialization uniform in at24_probe()drivers/ | +1 | 0 replies | |
| 9/21 | eeprom: at24: don't check if byte_len is a power of 2drivers/ | +0 | 0 replies | |
| 10/21 | eeprom: at24: rename at24_get_pdata()drivers/ | +3 | 0 replies | |
| 11/21 | eeprom: at24: rename chip to pdata in at24_probe()drivers/ | +21 | 0 replies | |
| 12/21 | eeprom: at24: use a helper variable for devdrivers/ | +23 | 0 replies | |
| 13/21 | eeprom: at24: readability tweak in at24_probe()drivers/ | +3 | 0 replies | |
| 14/21 | eeprom: at24: provide and use at24_base_client_dev()drivers/ | +7 | 0 replies | |
| 15/21 | eeprom: at24: switch to using probe_new() from the i2c frameworkdrivers/ | +5 | 0 replies | |
| 16/21 | eeprom: at24: move platform data processing into a separate routinedrivers/ | +40 | 0 replies | |
| 17/21 | eeprom: at24: remove at24_platform_data from at24_datadrivers/ | +13 | 0 replies | |
| 18/21 | eeprom: at24: refactor at24_probe()drivers/ | +18 | 0 replies | |
| 19/21 | eeprom: at24: tweak newlinesdrivers/ | +1 | 0 replies | |
| 20/21 | eeprom: at24: fix a line breakdrivers/ | +2 | 0 replies | |
| 21/21 | eeprom: at24: simplify the i2c functionality checkingdrivers/ | +7 | 0 replies |
Reviews trailers per patch
None of the 21 patches has a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| Series | T-b |
| 1/21 | T-b |
| 2/21 | T-b |
| 3/21 | T-b |
| 4/21 | |
| 5/21 | T-b |
| 6/21 | T-b |
| 7/21 | T-b |
| 8/21 | T-b |
| 9/21 | T-b |
| 10/21 | T-b |
| 11/21 | T-b |
| 12/21 | T-b |
| 13/21 | T-b |
| 14/21 | T-b |
| 15/21 | T-b |
| 16/21 | T-b |
| 17/21 | T-b |
| 18/21 | T-b |
| 19/21 | T-b |
| 20/21 | T-b |
| 21/21 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/21] eeprom: at24: driver refactoring
This series contains what I hope to be a non-controversial refactoring of the at24 eeprom driver.
Most changes revolve around at24_probe() which became quite complicated and hard to read.
The only functional changes are: disabling the internal locking mechanisms of regmap (since we already take care of that in the driver) and removing an if checking if byte_len is a power of 2 (as we do support models for which it's not true).
All other patches affect readability and code structure.
Tested with a couple models and different both for device tree and platform data modes.
Bartosz Golaszewski (21):
eeprom: at24: disable regmap locking
eeprom: at24: remove nvmem_config from at24_data
eeprom: at24: arrange local variables
eeprom: at24: use SPDX identifier instead of GPL boiler-plate
eeprom: at24: remove code separators
eeprom: at24: drop redundant variable in at24_read()
eeprom: at24: drop redundant variable in at24_write()
eeprom: at24: make struct initialization uniform in at24_probe()
eeprom: at24: don't check if byte_len is a power of 2
eeprom: at24: rename at24_get_pdata()
eeprom: at24: rename chip to pdata in at24_probe()
eeprom: at24: use a helper variable for dev
eeprom: at24: readability tweak in at24_probe()
eeprom: at24: provide and use at24_base_client_dev()
eeprom: at24: switch to using probe_new() from the i2c framework
eeprom: at24: move platform data processing into a separate routine
eeprom: at24: remove at24_platform_data from at24_data
eeprom: at24: refactor at24_probe()
eeprom: at24: tweak newlines
eeprom: at24: fix a line break
eeprom: at24: simplify the i2c functionality checking
drivers/misc/eeprom/at24.c | 293 ++++++++++++++++++++++++--------------------- 1 file changed, 156 insertions(+), 137 deletions(-)
Signature · 1 line
2.16.1