Skip to content

Support for Qualcomm UFS QMP PHY on SDM845

Can Guo linux-arm-msm linux-devicetree lkml 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest6 patches 3 repliesIn review
  2. v91 of 7 patches 0 repliesSuperseded
  3. v85 patches 8 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v74 patches9 repliesSuperseded
v63 patches6 repliesSuperseded
v53 patches4 repliesSuperseded
v42 patches0 repliesSuperseded
v32 patches6 repliesSuperseded
v22 patches6 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v10 from the cover letter

- Incorporated review comments from Rob.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6phy: Update PHY power control sequencedrivers/phy/qualcomm/phy-qcom-qmp.c+12 -70 replies
2/6phy: General struct and field cleanupdrivers/phy/qualcomm/phy-qcom-qmp.c+14 -110 replies
3/6phy: Add QMP phy based UFS phy support for sdm845drivers/phy/qualcomm/phy-qcom-qmp.c drivers/phy/qualcomm/phy-qcom-qmp.h+186 -10 replies
4/6scsi: ufs: Add core reset supportdrivers/scsi/ufs/ufs-qcom.c drivers/scsi/ufs/ufshcd-pltfrm.c drivers/scsi/ufs/ufshcd.c +1 more+77 -01 reply
5/6scsi: ufs: Power on phy after it is initializeddrivers/scsi/ufs/ufs-qcom.c drivers/scsi/ufs/ufs-qcom.h+4 -10 replies
6/6dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt+3 -10 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchManu GautamVivek GautamEvan GreenRob Herring
1/6R-b R-b R-b
2/6R-b R-b R-b
3/6R-b R-b
4/6
5/6R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v10 thread

Cover letter [PATCH v10 0/6] Support for Qualcomm UFS QMP PHY on SDM845

This patch series adds support for UFS QMP PHY on SDM845 and the
compatible string for it. This patch series depends on the current
proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on
the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also
rebased on updated pipe_clk initialization sequence [3]. This series
can only be merged once the dependent patches do.
[1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html
[2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html
[3] https://patchwork.kernel.org/patch/10376551/

Changes since v9:
- Incorporated review comments from Rob.

Changes since v8:
- Add one new change to support ufs core reset.
- Incorporated review comments from Evan, Vivek.

Changes since v7:
- Add one new change to update UFS PHY power on sequence
- Incorporated review comments from Evan, Vivek and Manu.

Changes since v6:
- Add one new change to clean up some structs and field
- Updates the PHY power control sequence.
- Incorporated review comments from Vivek and Manu.

Changes since v5:
- Updates the PHY power control sequence.
- Updates UFS PHY power on condition check.

Changes since v4:
- Adds 'ref_aux' clock back to SDM845 UFS PHY clock list.
- Power on PHY before serdes configuration starts.
- Updates the UFS PHY initialization sequence.
- Updates a few UFS PHY registers.
- Incorporated review comments from Vivek and Manu.

Changes since v3:
- Incorporated review comments from Vivek and Rob.

Changes since v2:
- Incorporated review comments from Vivek and Rob.
- Remove "ref_aux" from sdm845 ufs phy clock list structure.

Changes since v1:
- Incorporated review comments from Vivek and Manu.
- Update the commit title of patch 2.

Can Guo (5):
phy: Update PHY power control sequence
phy: General struct and field cleanup
phy: Add QMP phy based UFS phy support for sdm845
scsi: ufs: Power on phy after it is initialized
dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845

Dov Levenglick (1):
scsi: ufs: Add core reset support

 .../devicetree/bindings/phy/qcom-qmp-phy.txt       |   4 +-
 drivers/phy/qualcomm/phy-qcom-qmp.c                | 216 +++++++++++++++++++--
 drivers/phy/qualcomm/phy-qcom-qmp.h                |  15 ++
 drivers/scsi/ufs/ufs-qcom.c                        |  34 +++-
 drivers/scsi/ufs/ufs-qcom.h                        |   1 +
 drivers/scsi/ufs/ufshcd-pltfrm.c                   |  22 +++
 drivers/scsi/ufs/ufshcd.c                          |  13 ++
 drivers/scsi/ufs/ufshcd.h                          |  12 ++
 8 files changed, 296 insertions(+), 21 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project