block: Follow-up for .bdrv_co_create (part 1)
Status from this message: Applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest12 patches 4 repliesApplied
- v112 patches 21 repliesSuperseded
Changes in v2 from the cover letter
- Patch 1: Mention allowed values for 'preallocation' [Eric]
- Patch 3: Fixed comments, removed 2^63-512 case [Eric]
- Patch 6: Added missing reference output change [Eric]
- Patch 7: s/UINT64_MAX/INT64_MAX/ [Eric]
- Patches 8 and 12: Fixed comments [Eric]
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | vdi: Change 'static' create option to 'preallocation' in QMPblock/ qapi/ | +25 | 1 reply | |
| 2/12 | vdi: Fix build with CONFIG_VDI_DEBUGblock/ | +10 | 0 replies | |
| 3/12 | qemu-iotests: Test vdi image creation with QMPtests/ tests/ tests/ | +344 | 1 reply | |
| 4/12 | qemu-iotests: Enable 025 for lukstests/ | +8 | 0 replies | |
| 5/12 | luks: Turn another invalid assertion into checkblock/ | +5 | 0 replies | |
| 6/12 | qemu-iotests: Test invalid resize on lukstests/ tests/ | +53 | 1 reply | |
| 7/12 | parallels: Check maximum cluster size on createblock/ | +5 | 0 replies | |
| 8/12 | qemu-iotests: Test parallels image creation with QMPtests/ tests/ tests/ | +438 | 0 replies | |
| 9/12 | vhdx: Require power-of-two block size on createblock/ | +4 | 0 replies | |
| 10/12 | vhdx: Don't use error_setg_errno() with constant errnoblock/ | +4 | 0 replies | |
| 11/12 | vhdx: Check for 4 GB maximum log size on creationblock/ | +4 | 0 replies | |
| 12/12 | qemu-iotests: Test vhdx image creation with QMPtests/ tests/ tests/ | +471 | 0 replies |
Reviews trailers per patch
10 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Daniel P. Berrangé | Jeff Cody |
|---|---|---|---|
| 1/12 | R-b | ||
| 2/12 | R-b | ||
| 3/12 | R-b | ||
| 4/12 | R-b | R-b | |
| 5/12 | R-b | R-b | |
| 6/12 | R-b | ||
| 7/12 | R-b | ||
| 8/12 | |||
| 9/12 | R-b | R-b | |
| 10/12 | R-b | R-b | |
| 11/12 | R-b | R-b | |
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH for-2.12 v2 00/12] block: Follow-up for .bdrv_co_create (part 1)
This series adds qemu-iotests for a few more block drivers (yet more to come in another series) and fixes a few things that previous review and these tests brought up.
The only major design change is that I converted the vdi block driver from a boolean 'static' create option to the standard 'preallocation' one that other drivers are using. This seems like a good move to make while the interface isn't stable yet.
v2:
- Patch 1: Mention allowed values for 'preallocation' [Eric]
- Patch 3: Fixed comments, removed 2^63-512 case [Eric]
- Patch 6: Added missing reference output change [Eric]
- Patch 7: s/UINT64_MAX/INT64_MAX/ [Eric]
- Patches 8 and 12: Fixed comments [Eric]
Kevin Wolf (12):
vdi: Change 'static' create option to 'preallocation' in QMP
vdi: Fix build with CONFIG_VDI_DEBUG
qemu-iotests: Test vdi image creation with QMP
qemu-iotests: Enable 025 for luks
luks: Turn another invalid assertion into check
qemu-iotests: Test invalid resize on luks
parallels: Check maximum cluster size on create
qemu-iotests: Test parallels image creation with QMP
vhdx: Require power-of-two block size on create
vhdx: Don't use error_setg_errno() with constant errno
vhdx: Check for 4 GB maximum log size on creation
qemu-iotests: Test vhdx image creation with QMP
qapi/block-core.json | 7 +- block/crypto.c | 6 +- block/parallels.c | 5 + block/vdi.c | 46 ++++-- block/vhdx.c | 17 ++- tests/qemu-iotests/025 | 9 +- tests/qemu-iotests/210 | 37 +++++ tests/qemu-iotests/210.out | 16 +++ tests/qemu-iotests/211 | 246 ++++++++++++++++++++++++++++++++ tests/qemu-iotests/211.out | 97 +++++++++++++ tests/qemu-iotests/212 | 326 ++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/212.out | 111 ++++++++++++++ tests/qemu-iotests/213 | 349 +++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/213.out | 121 ++++++++++++++++ tests/qemu-iotests/group | 3 + 15 files changed, 1371 insertions(+), 25 deletions(-) create mode 100755 tests/qemu-iotests/211 create mode 100644 tests/qemu-iotests/211.out create mode 100755 tests/qemu-iotests/212 create mode 100644 tests/qemu-iotests/212.out create mode 100755 tests/qemu-iotests/213 create mode 100644 tests/qemu-iotests/213.out
Signature · 1 line
2.13.6