Skip to content

Use bsearch_hash() for abbreviations

Derrick Stolee git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesIn review
  2. v11 patch 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sha1_name: convert struct min_abbrev_data to object_idsha1_name.c+3 -30 replies
2/3packfile: define and use bsearch_pack()packfile.c packfile.h+34 -160 replies
3/3sha1_name: use bsearch_pack() for abbreviationssha1_name.c+4 -200 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDerrick Stolee
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Use bsearch_hash() for abbreviations

Thanks to Jonathan and Brian for the help with the proper way to handle OIDs and existing callers to bsearch_hash(). This patch includes one commit that Brian sent in the previous discussion (included again here for completeness).

Derrick Stolee (2):
packfile: define and use bsearch_pack()
sha1_name: use bsearch_pack() for abbreviations

brian m. carlson (1):
sha1_name: use bsearch_hash() for abbreviations

 packfile.c  | 42 ++++++++++++++++++++++++++----------------
 packfile.h  |  8 ++++++++
 sha1_name.c | 28 ++++++----------------------
 3 files changed, 40 insertions(+), 38 deletions(-)

base-commit: 1a750441a7360b29fff7a414649ece1d35acaca6

Signature · 1 line
2.17.0.rc0