Salted build ids via linker sections
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 11 repliesIn review
- v32 patches 10 repliesSuperseded
- v2 RFC3 patches 9 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 3 patches | 3 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scripts: Preprocess module-common.ldsscripts/ scripts/ scripts/ | +2 | 4 replies | |
| 2/3 | kbuild: Introduce build-salt linker section and config optioninclude/ init/ scripts/ | +19 | 2 replies | |
| 3/3 | x86: Add build salt to the vDSO and kernel linker scriptsarch/ arch/ | +3 | 3 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Ingo Molnar |
|---|---|
| 1/3 | |
| 2/3 | |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv4 0/3] Salted build ids via linker sections
Hi,
This is v4 of the series to allow unique build ids in the kernel. As a reminder of the context:
""
In Fedora, the debug information is packaged separately (foo-debuginfo) and can be installed separately. There's been a long standing issue where only one version of a debuginfo info package can be installed at a time. Mark Wielaard made an effort for Fedora 27 to allow parallel installation of debuginfo (see
https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo for more details)
Part of the requirement to allow this to work is that build ids are unique between builds. The existing upstream rpm implementation ensures this by re-calculating the build-id using the version and release as a seed. This doesn't work 100% for the kernel because of the vDSO which is its own binary and doesn't get updated. After poking holes in a few of my ideas, there was a discussion with some people from the binutils team about adding --build-id-salt to let ld do the calculation debugedit is doing. There was a counter proposal made to add in the salt while building. The easiest proposal was to add an item in the linker script vs. linking in an object since we need the salt to go in every module as well as the kernel and vmlinux.
""
v4 takes Linus' suggestion of using linker fill to insert the build id. This removes the need to use a generated header which makes things much easier. One change is that because this section isn't .comment it won't get stripped automatically. This is pretty small but I also know people can be picky so I'm open to opinions or suggestions here.
Laura Abbott (3):
scripts: Preprocess module-common.lds
kbuild: Introduce build-salt linker section and config option
x86: Add build salt to the vDSO and kernel linker scripts
arch/x86/entry/vdso/vdso-layout.lds.S | 3 ++-
arch/x86/kernel/vmlinux.lds.S | 1 +
include/asm-generic/vmlinux.lds.h | 6 ++++++
init/Kconfig | 9 +++++++++
scripts/.gitignore | 1 +
scripts/Makefile | 2 +-
scripts/{module-common.lds => module-common.lds.S} | 4 ++++
7 files changed, 24 insertions(+), 2 deletions(-)
rename scripts/{module-common.lds => module-common.lds.S} (94%)Signature · 1 line
2.18.0.rc1