tests: trivial enhancements for OOB
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tests: let qapi-schema tests detect oobtests/ tests/ tests/ +2 more | +16 | 1 reply | |
| 2/3 | tests: add oob-test for qapi-schematests/ tests/ tests/ +2 more | +10 | 2 replies | |
| 3/3 | tests: more strict command batching testtests/ | +7 | 2 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/3 | R-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/3] tests: trivial enhancements for OOB
First two patches add OOB detection for current qapi-schema tests (which I missed in the OOB series but pointed out by Eric Blake). The 3rd patch addressed one suggestion from Eric too here:
http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03177.html
I tried to batch the commands in a single string buffer but it's not that easy - because currently qtest_async_qmp() (and finally, qmp_fd_sendv()) does not really support multiple qobjects in a single command buffer. Let's put that aside. After all even calling qtest_async_qmp() many times would be really fast, since we are basically filling things to the write buffer very quickly (I believe that's much faster than the IO really flushed to the receiver side).
But, adding the "id" field and check that would be far easier, that's what I did in that last patch.
It's fine even for 2.12, but I'll let people decide.
Please review, thanks.
Peter Xu (3):
tests: let qapi-schema tests detect oob
tests: add oob-test for qapi-schema
tests: more strict command batching test
tests/Makefile.include | 1 + tests/qapi-schema/doc-good.out | 4 ++-- tests/qapi-schema/ident-with-escape.out | 2 +- tests/qapi-schema/indented-expr.out | 4 ++-- tests/qapi-schema/oob-test.err | 0 tests/qapi-schema/oob-test.exit | 1 + tests/qapi-schema/oob-test.json | 2 ++ tests/qapi-schema/oob-test.out | 6 ++++++ tests/qapi-schema/qapi-schema-test.out | 18 +++++++++--------- tests/qapi-schema/test-qapi.py | 4 ++-- tests/qmp-test.c | 8 +++++++- 11 files changed, 33 insertions(+), 17 deletions(-) create mode 100644 tests/qapi-schema/oob-test.err create mode 100644 tests/qapi-schema/oob-test.exit create mode 100644 tests/qapi-schema/oob-test.json create mode 100644 tests/qapi-schema/oob-test.out
Signature · 1 line
2.14.3