Skip to content

ARM: davinci: complete the conversion to using the reset framework

Bartosz Golaszewski linux-arm-kernel linux-clk linux-devicetree linux-remoteproc lkml 8 versions – Applied

Status from this message: Applied to v4.19/dt branch of my tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 16 repliesApplied
  2. v67 patches 9 repliesSuperseded
  3. v58 patches 7 repliesApplied
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v3 posting 2/28 patches7 repliesSuperseded
v48 patches16 repliesSuperseded
v3 posting 1/28 patches1 replySuperseded
v28 patches3 repliesSuperseded
v18 patches8 repliesSuperseded

Changes in v7 from the cover letter

- rebased on top of v4.18-rc1 and dropped patches that were applied for v4.17

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/4remoteproc/davinci: use the reset frameworkdrivers/remoteproc/da8xx_remoteproc.c+29 -54 replies
2/4clk: davinci: kill davinci_clk_reset_assert/deassert()arch/arm/mach-davinci/include/mach/clock.h drivers/clk/davinci/psc.c+0 -394 replies
3/4ARM: davinci: dts: make psc0 a reset providerarch/arm/boot/dts/da850.dtsi+1 -01 reply
4/4ARM: davinci: dts: add a reset control to the dsp nodearch/arm/boot/dts/da850.dtsi+1 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchSekhar NoriPhilipp ZabelDavid LechnerStephen BoydBjorn Andersson
1/4R-b R-b A-b
2/4R-b A-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/4] ARM: davinci: complete the conversion to using the reset framework

From: Bartosz Golaszewski <[email protected]>

These are the remaining patches that still need to be merged in order to complete the conversion of the davinci dsp driver to using the reset framework.

They apply on top of v4.18-rc1 with David Lechner's remaining patches merged.

v1 -> v2:
- fixed the device tree patches the descriptions of which were mixed up
- return -EPROBE_DEFER from davinci-rproc's probe() if we can't get the reset provider, since it's possible that the lookup table was not yet registered
- made the local variable naming consistent in the davinci-rproc driver
- fixed a typo in PATCH 5/8

v2 -> v3:
- modify PATCH 1/8: drop the provider argument from the function adding lookup entries and instead pass the provider name to the RESET_LOOKUP macro, return -EPROBE_DEFER if we locate a correct lookup entry but cannot get the corresponding reset controller
- modify the reset lookup entry in psc-da850
- don't manually return -EPROBE_DEFER from davinci-rproc, instead don't emit an error message if devm_reset_control_get_exclusive() returns this error code

v3 -> v4:
- make index the second parameter in RESET_LOOKUP() (right after the provider name)

v4 -> v5:
- fix a bug where the dsp_reset object correctly stored in drproc struct

v5 -> v6:
- rebased on top of v4.17-rc1 and retested
- dropped patches that were applied during 4.17 merge window
- added relevant review and ack tags

v6 -> v7:
- rebased on top of v4.18-rc1 and dropped patches that were applied for v4.17

Bartosz Golaszewski (4):
remoteproc/davinci: use the reset framework
clk: davinci: kill davinci_clk_reset_assert/deassert()
ARM: davinci: dts: make psc0 a reset provider
ARM: davinci: dts: add a reset control to the dsp node

 arch/arm/boot/dts/da850.dtsi               |  2 ++
 arch/arm/mach-davinci/include/mach/clock.h | 21 -------------
 drivers/clk/davinci/psc.c                  | 18 ------------
 drivers/remoteproc/da8xx_remoteproc.c      | 34 ++++++++++++++++++----
 4 files changed, 31 insertions(+), 44 deletions(-)
 delete mode 100644 arch/arm/mach-davinci/include/mach/clock.h
Signature · 1 line
2.17.1