completion: add option completion for most builtin commands
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 1 replyIn review
- v11 patch 7 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | git.c: move cmd_struct declaration upgit.c | +17 | 0 replies | |
| 2/8 | git.c: add hidden option --list-parseopt-builtinsgit.c | +49 | 0 replies | |
| 3/8 | completion: mention the oldest version we need to supportcontrib/ | +2 | 0 replies | |
| 4/8 | completion: factor out _git_xxx calling codecontrib/ | +13 | 0 replies | |
| 5/8 | completion: add --option completion for most builtin commandscontrib/ t/ | +34 | 1 reply | |
| 6/8 | completion: delete option-only completion commandscontrib/ | +0 | 0 replies | |
| 7/8 | completion: use __gitcomp_builtin in _git_ls_treecontrib/ | +7 | 0 replies | |
| 8/8 | completion: use __gitcomp_builtin in _git_cherrycontrib/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/8] completion: add option completion for most builtin commands
This series adds option completion for many more commands. More importantly it introduces a generic completion function __git_complete_common(). With --git-completion-helper providing more and more information in future, this function can start to replace many other _git_xxx() in this file.
Nguyễn Thái Ngọc Duy (8):
git.c: move cmd_struct declaration up
git.c: add hidden option --list-parseopt-builtins
completion: mention the oldest version we need to support
completion: factor out _git_xxx calling code
completion: add --option completion for most builtin commands
completion: delete option-only completion commands
completion: use __gitcomp_builtin in _git_ls_tree
completion: use __gitcomp_builtin in _git_cherry
contrib/completion/git-completion.bash | 75 +++++++++++---- git.c | 122 +++++++++++++------------ t/t9902-completion.sh | 6 ++ 3 files changed, 127 insertions(+), 76 deletions(-)
Signature · 1 line
2.17.0.rc0.348.gd5a49e0b6f