Skip to content

serial: implement flow control for ASPEED VUART driver

Greg Kroah-Hartman linux-aspeed openbmc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 5 patches 0 repliesNew

2 of 5 patches are in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5serial: Introduce UPSTAT_SYNC_FIFO for synchronised FIFOs+0 -01 reply
2/5serial: expose buf_overrun count through proc interface+0 -01 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchEddie JamesJoel Stanley
SeriesT-b T-b T-b T-b T-b
1/5
2/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] serial: implement flow control for ASPEED VUART driver
Quoted 9 lines · Jeremy Kerr

This series implements flow control for the ASPEED VUART driver. This hardware is slightly unusual in that the RX data rate can quickly overwhelm the flip buffer code, so the ldisc-driven throttle/unthrottle mechanisms don't entirely solve the problem.

To do this, we have a couple of minor changes to the tty core, as well as an update to the tty proc interface to display buffer overrun metrics (entirely optional, but does allow us to see the problem).

Quoted 5 lines

Then, we implement the standard throttle mechanism, and augment it with a fast-path to throttle if we overrun the flip buffers before the ldisc has had a chance to run.

Questions and comments most welcome; I'm fairly new to the tty layer.

I've applied patch 2 here, can you redo the series again after fixing up the first one and include the v2 of patch 5 so it's easier for me to figure out what to really apply here?

thanks,

greg k-h