Monitor: some oob related patches (fixes, new param, tests)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 20 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | qmp: fix qmp_capabilities error regressionmonitor.c | +8 | 2 replies | |
| 2/8 | qmp: cleanup qmp queues properlymonitor.c | +59 | 3 replies | |
| 3/8 | monitor: new parameter "x-oob"include/ monitor.c vl.c | +26 | 3 replies | |
| 4/8 | qapi: restrict allow-oob value to be "true"scripts/ | +1 | 2 replies | |
| 5/8 | tests: let qapi-schema tests detect oobtests/ tests/ tests/ +2 more | +16 | 1 reply | |
| 6/8 | tests: add oob-test for qapi-schematests/ tests/ tests/ +5 more | +14 | 2 replies | |
| 7/8 | tests: introduce qtest_init_with_qmp_format()tests/ tests/ | +25 | 3 replies | |
| 8/8 | tests: qmp-test: add test for new "x-oob"tests/ | +84 | 1 reply |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Marc-André Lureau |
|---|---|---|
| 1/8 | R-b | R-b |
| 2/8 | R-b | |
| 3/8 | R-b | |
| 4/8 | R-b | R-b |
| 5/8 | R-b | R-b |
| 6/8 | R-b | R-b |
| 7/8 | R-b | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH for-2.12 0/8] Monitor: some oob related patches (fixes, new param, tests)
I suppose these are all good even for 2.12, so marked in subject. Tested with "make check" for all targets on x86_64, and iotest -raw.
Patch 1 fixes one OOB error message regression reported by Marc-Andre.
Patch 2 fixes one potential OOB problem when more than one clients are there, reported by Marc-Andre (too).
Patch 3 introduce "-mon x-oob=on" parameter to allow user to explicitly enable Out-Of-Band for a specific monitor.
Patch 4-6 are qapi-schema fixes and tests for Out-Of-Band.
Patch 7-8 add back the OOB test on the new parameter (with more enhancements).
Please review, thanks.
Peter Xu (8):
qmp: fix qmp_capabilities error regression
qmp: cleanup qmp queues properly
monitor: new parameter "x-oob"
qapi: restrict allow-oob value to be "true"
tests: let qapi-schema tests detect oob
tests: add oob-test for qapi-schema
tests: introduce qtest_init_with_qmp_format()
tests: qmp-test: add test for new "x-oob"
include/monitor/monitor.h | 1 + monitor.c | 124 ++++++++++++++++++++++---------- scripts/qapi/common.py | 2 +- tests/Makefile.include | 1 + tests/libqtest.c | 14 +++- tests/libqtest.h | 14 ++++ tests/qapi-schema/doc-good.out | 4 +- tests/qapi-schema/ident-with-escape.out | 2 +- tests/qapi-schema/indented-expr.out | 4 +- tests/qapi-schema/oob-test.err | 1 + tests/qapi-schema/oob-test.exit | 1 + tests/qapi-schema/oob-test.json | 2 + tests/qapi-schema/oob-test.out | 0 tests/qapi-schema/qapi-schema-test.json | 3 + tests/qapi-schema/qapi-schema-test.out | 20 +++--- tests/qapi-schema/test-qapi.py | 4 +- tests/qmp-test.c | 84 ++++++++++++++++++++++ tests/test-qmp-cmds.c | 4 ++ vl.c | 5 ++ 19 files changed, 233 insertions(+), 57 deletions(-) create mode 100644 tests/qapi-schema/oob-test.err create mode 100644 tests/qapi-schema/oob-test.exit create mode 100644 tests/qapi-schema/oob-test.json create mode 100644 tests/qapi-schema/oob-test.out
Signature · 1 line
2.14.3