Skip to content

improve OPAL cosole flushing and locking

Nicholas Piggin linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6powerpc/powernv: opal-kmsg use flush fallback from console codearch/powerpc/platforms/powernv/opal-kmsg.c+6 -91 reply
2/6powerpc/powernv: Implement and use opal_flush_consolearch/powerpc/include/asm/opal.h arch/powerpc/platforms/powernv/opal-kmsg.c arch/powerpc/platforms/powernv/opal.c+42 -361 reply
3/6powerpc/powernv: Remove OPALv1 support from opal console driverarch/powerpc/platforms/powernv/opal.c+40 -460 replies
4/6powerpc/powernv: move opal console flushing to udbgarch/powerpc/platforms/powernv/opal.c drivers/tty/hvc/hvc_opal.c+12 -50 replies
5/6powerpc/powernv: implement opal_put_chars_nonatomicarch/powerpc/include/asm/opal.h arch/powerpc/platforms/powernv/opal.c drivers/tty/hvc/hvc_opal.c+28 -124 replies
6/6drivers/tty/hvc: remove unexplained "just in case" spin delaydrivers/tty/hvc/hvc_opal.c+1 -71 reply

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchBenjamin HerrenschmidtRussell Currey
1/6R-b
2/6R-b
3/6
4/6
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] improve OPAL cosole flushing and locking

This series of patches aims to improve the robustness of the OPAL console by simplifying and removing locks. If this code is interrupted due to a panic or xmon request, it may block the xmon IO or panic console flush because they use the opal console too.

So reducing locking and relaxing atomicity requirements is important for improving kernel debugging.

Nicholas Piggin (6):
powerpc/powernv: opal-kmsg use flush fallback from console code powerpc/powernv: Implement and use opal_flush_console powerpc/powernv: Remove OPALv1 support from opal console driver powerpc/powernv: move opal console flushing to udbg powerpc/powernv: implement opal_put_chars_nonatomic drivers/tty/hvc: remove unexplained "just in case" spin delay

 arch/powerpc/include/asm/opal.h            |   2 +
 arch/powerpc/platforms/powernv/opal-kmsg.c |  38 +-----
 arch/powerpc/platforms/powernv/opal.c      | 141 ++++++++++++++-------
 drivers/tty/hvc/hvc_opal.c                 |  17 ++-
 4 files changed, 106 insertions(+), 92 deletions(-)
Signature · 1 line
2.17.0