Skip to content

USB: musb: dsps: phy fix and DT-topology support

Johan Hovold linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3USB: musb: dsps: drop duplicate phy initialisationdrivers/usb/musb/musb_dsps.c+0 -21 reply
2/3USB: musb: host: prevent core phy initialisationdrivers/usb/musb/musb_host.c+1 -00 replies
3/3USB: musb: dsps: propagate device-tree nodedrivers/usb/musb/musb_dsps.c+1 -02 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchUwe Kleine-König
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support

I've been carrying a patch out-of-tree since my work on improving the USB device-tree support which is needed to be able to describe USB topologies for musb based controllers.

This patch, which associates the platform controller device with the glue device device-tree node, did not play well with the recent changes which added generic phy support to USB core however.

Like the recent dwc2 regression fixed by Arnd after the device-tree #phy-cell changes, the generic phy code in USB core can now also fail indefinitly with -EPROBE_DEFER when the controller uses a legacy USB phy.

The second patch addresses this for musb, which handles its own (legacy and generic) phys, but something more may possibly now be needed for other platforms with legacy phys.

In the process of debugging this, I stumbled over another issue which caused the dsps legacy phy init two be called twice on every probe and which is fixed by the first patch.

Johan

Johan Hovold (3):
USB: musb: dsps: drop duplicate phy initialisation
USB: musb: host: prevent core phy initialisation
USB: musb: dsps: propagate device-tree node

 drivers/usb/musb/musb_dsps.c | 3 +--
 drivers/usb/musb/musb_host.c | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.0