Fix keep-alive mechanism for fabrics
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 of 5 patches 0 repliesNew
1 of 5 patches is in this archive. The cover letter announces 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/5 | nvme: remove association between ctrl and keep-alive | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH v1 0/5] Fix keep-alive mechanism for fabrics
Quoted 4 lines · Max Gurtovoy
I've noticed that there is no clear definition in the NVMe spec regarding the keep-alive mechanism association. IMO, it should be a property of the admin queue and should be triggered as soon as the admin queue configured successfuly.
It is a property of the controller, sent over the admin queue. I'm not sure what else it could be, but if things are confusing please reach out to the technical working group.
Note that we can only send NVMe command (rather than Fabrics commands) when the controller is enabled. Based on that I think that we need to fix keep alive, but in a different way than in this series.
So instead of starting keep alive in nvme_start_ctrl we should start in nvme_enable_ctrl, and similar on the stop side with disable/shutdown. On the target side we can also only start to expect a a keep-alive once the controller has been enabled, and need to stop expecting one once the controller has been disabled.