qemu-nbd: Disallow listing exports
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | nbd: Add option to disallow listing exportsblockdev-nbd.c include/ nbd/ +2 more | +19 | 6 replies | |
| 2/3 | iotests.py: Add helper for running commandstests/ | +18 | 0 replies | |
| 3/3 | qemu-iotests: Test new qemu-nbd --nolist optiontests/ tests/ tests/ | +49 | 2 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Richard W.M. Jones |
|---|---|
| 1/3 | T-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/3] qemu-nbd: Disallow listing exports
oVirt uses random URLs to expose images temporarily via HTTPS. We would like to integrated qemu-nbd in the same system, proving a user an easy and uniform way to access an image - either using HTTPS:
https://server:54322/images/dc72d3cc-b933-45e8-89a2-e028e1c2ef3d
Or using NBD over TLS:
nbd://server:10809/dc72d3cc-b933-45e8-89a2-e028e1c2ef3d
Unfortunatly, qemu-nbd allows listing exports by default. Allowing anyone to find the secret export using easy to guess port number.
These patches:
- add --nolist option to qemu-nbd, disabling NBD_OPT_LIST command.
- add some infrastructure ot iotests.py
- and use the new infrastructure to add test the new option using nbd-client.
Adding dependency on nbd-client may be probelematic, but I think qemu-nbd should have tests ensuring compatibility with other tools.
Nir Soffer (3):
nbd: Add option to disallow listing exports
iotests.py: Add helper for running commands
qemu-iotests: Test new qemu-nbd --nolist option
blockdev-nbd.c | 2 +- include/block/nbd.h | 1 + nbd/server.c | 7 +++++++ qemu-nbd.c | 9 ++++++++- qemu-nbd.texi | 2 ++ tests/qemu-iotests/214 | 46 +++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/214.out | 2 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 18 +++++++++++++++++ 9 files changed, 86 insertions(+), 2 deletions(-) create mode 100755 tests/qemu-iotests/214 create mode 100644 tests/qemu-iotests/214.out
Signature · 1 line
2.14.3