Skip to content

Fix an Atmel USBA UDC issue introducted in 4.17-rc1

Romain Izard linux-arm-kernel linux-usb lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Use the correct format for the "Fixes:" tag
- Collect "Acked-by:" tags

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3usb: gadget: udc: atmel: GPIO inversion is handled by gpioddrivers/usb/gadget/udc/atmel_usba_udc.c drivers/usb/gadget/udc/atmel_usba_udc.h+1 -30 replies
2/3usb: gadget: udc: atmel: Remove obsolete includedrivers/usb/gadget/udc/atmel_usba_udc.c include/linux/usb/atmel_usba_udc.h+0 -250 replies
3/3usb: gadget: udc: atmel: Fix indentingdrivers/usb/gadget/udc/atmel_usba_udc.c+9 -90 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchLudovic DesrochesNicolas Ferre
1/3A-b A-b
2/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1

The use of GPIO descriptors takes care of inversion flags declared in the device tree. The conversion of the Atmel USBA UDC driver introduced in 4.17-rc1 missed it, and as a result the inversion will not work.

In addition, cleanup the code to remove an include left behind after the suppression of the support of platform_data to declare USBA controllers.

These changes have not been tested on any hardware, as I do not have a board that needs to use inverted GPIOs.

--
Changes in v2:
- Use the correct format for the "Fixes:" tag
- Collect "Acked-by:" tags

Romain Izard (3):
usb: gadget: udc: atmel: GPIO inversion is handled by gpiod
usb: gadget: udc: atmel: Remove obsolete include
usb: gadget: udc: atmel: Fix indenting

 drivers/usb/gadget/udc/atmel_usba_udc.c | 22 ++++++++++------------
 drivers/usb/gadget/udc/atmel_usba_udc.h |  1 -
 include/linux/usb/atmel_usba_udc.h      | 24 ------------------------
 3 files changed, 10 insertions(+), 37 deletions(-)
 delete mode 100644 include/linux/usb/atmel_usba_udc.h
Signature · 1 line
2.14.1