Skip to content

fixes from 2018-04-17 - v3

Ursula Braun linux-s390 netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 1 replySuperseded
  3. v14 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net/smc: fix structure sizenet/smc/smc_cdc.c net/smc/smc_cdc.h+2 -20 replies
2/4net/smc: handle sockopts forcing fallbacknet/smc/af_smc.c+50 -40 replies
3/4net/smc: sockopts TCP_NODELAY and TCP_CORKnet/smc/af_smc.c net/smc/smc_tx.c+40 -40 replies
4/4net/smc: handle sockopt TCP_DEFER_ACCEPTnet/smc/af_smc.c net/smc/smc.h net/smc/smc_rx.c +1 more+31 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/4] fixes from 2018-04-17 - v3

From: Ursula Braun <[email protected]>

Dave,

in the mean time we challenged the benefit of these CLC handshake optimizations for the sockopts TCP_NODELAY and TCP_CORK.
We decided to give up on them for now, since SMC still works properly without.
There is now version 3 of the patch series with patches 2-4 implementing sockopts that require special handling in SMC.

Version 3 changes
* no deferring of setsockopts TCP_NODELAY and TCP_CORK anymore
* allow fallback for some sockopts eliminating SMC usage
* when setting TCP_NODELAY always enforce data transmission (not only together with corked data)

Version 2 changes of Patch 2/4 (and 3/4):
* return error -EOPNOTSUPP for TCP_FASTOPEN sockopts
* fix a kernel_setsockopt() usage bug by switching parameter variable from type "u8" to "int"
* add return code validation when calling kernel_setsockopt()
* propagate a setsockopt error on the internal CLC socket to the SMC socket.

Regards, Ursula

Karsten Graul (1):
net/smc: fix structure size

Ursula Braun (3):
net/smc: handle sockopts forcing fallback
net/smc: handle sockopt TCP_CORK
net/smc: handle sockopt TCP_DEFER_ACCEPT

 net/smc/af_smc.c  | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
 net/smc/smc.h     |  4 +++
 net/smc/smc_cdc.c |  2 +-
 net/smc/smc_cdc.h |  2 +-
 net/smc/smc_rx.c  |  2 +-
 net/smc/smc_rx.h  |  1 +
 net/smc/smc_tx.c  | 24 ++++++++++++--
 7 files changed, 122 insertions(+), 11 deletions(-)
Signature · 1 line
2.13.5