Skip to content

scsi: scsi-mq: don't hold host_busy in IO path

Ming Lei linux-block 2 versions – Applied

Status from this message: Applied to 4.19/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesApplied
  2. v13 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- merge patch 1&2 into one patch
- run more tests(blktests, xfstests, ...), and not see regression

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: read host_busy via scsi_host_busy()drivers/scsi/advansys.c drivers/scsi/hosts.c drivers/scsi/libsas/sas_scsi_host.c +7 more+26 -151 reply
2/2scsi: avoid to hold host-wide counter of host_busy for scsi_mqdrivers/scsi/hosts.c drivers/scsi/scsi_lib.c+40 -75 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBart Van Assche
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/2] scsi: scsi-mq: don't hold host_busy in IO path

Hi,

This patches removes the expensive atomic opeation on host-wide counter of .host_busy for scsi-mq, and it is observed that IOPS can be increased by 15% with this change in IO test over scsi_debug.

V2:
- merge patch 1&2 into one patch
- run more tests(blktests, xfstests, ...), and not see regression

Ming Lei (2):
scsi: read host_busy via scsi_host_busy()
scsi: avoid to hold host-wide counter of host_busy for scsi_mq

 drivers/scsi/advansys.c                   |  8 ++++----
 drivers/scsi/hosts.c                      | 32 +++++++++++++++++++++++++++++++
 drivers/scsi/libsas/sas_scsi_host.c       |  4 ++--
 drivers/scsi/megaraid/megaraid_sas_base.c |  2 +-
 drivers/scsi/mpt3sas/mpt3sas_base.c       |  4 ++--
 drivers/scsi/qlogicpti.c                  |  2 +-
 drivers/scsi/scsi.c                       |  2 +-
 drivers/scsi/scsi_error.c                 |  6 +++---
 drivers/scsi/scsi_lib.c                   | 23 ++++++++++++++++------
 drivers/scsi/scsi_sysfs.c                 |  2 +-
 include/scsi/scsi_host.h                  |  1 +
 11 files changed, 65 insertions(+), 21 deletions(-)
Cc Omar Sandoval <[email protected]>,
Cc "Martin K. Petersen" <[email protected]>,
Cc James Bottomley <[email protected]>,
Cc Christoph Hellwig <[email protected]>,
Cc Don Brace <[email protected]>
Cc Kashyap Desai <[email protected]>
Cc Mike Snitzer <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Laurence Oberman <[email protected]>
Cc Bart Van Assche <[email protected]>
Signature · 1 line
2.9.5