Skip to content

RFC print_uint issues

Stephen Hemminger netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ipneigh: fix missing format specifierip/ipneigh.c+1 -10 replies
2/5json: make json print_uint take unsigned intinclude/json_print.h lib/json_print.c+43 -60 replies
3/5flower: use 16 bit format where possibletc/f_flower.c+1 -10 replies
4/5tcp_metrics: use print_luintip/tcp_metrics.c+1 -10 replies
5/5mroute: use print_uint64ip/ipmroute.c+5 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC iproute 0/5] print_uint issues

There are several issues with implicit conversions in json handling print_uint function which were first seen and patches proposed by Alin Nastac. This is my swipe at them.

Final version will be some combination of his patches and some of this.

Spotted some more changing print_uint into a macro, but that got ugly.

Stephen Hemminger (5):
ipneigh: fix missing format specifier
json: make json print_uint take unsigned int
flower: use 16 bit format where possible
tcp_metrics: use print_luint
mroute: use print_uint64

 include/json_print.h | 16 +++++++++++++---
 ip/ipmroute.c        | 10 +++++-----
 ip/ipneigh.c         |  2 +-
 ip/tcp_metrics.c     |  2 +-
 lib/json_print.c     | 33 ++++++++++++++++++++++++++++++---
 tc/f_flower.c        |  2 +-
 6 files changed, 51 insertions(+), 14 deletions(-)
Signature · 1 line
2.17.0