RFC Add fastboot UDP support
Get series with b4
b4 am 20180425094022.3eb559ee@jawaVersions newest first
- v1 RFC Latest3 of 5 patches 0 repliesNew
3 of 5 patches are in this archive. The cover letter announces 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | dfu: Refactor fastboot_okay/fail to take response | +0 | 1 reply | |
| 2/5 | dfu: Extract fastboot_okay/fail to fb_common.c | +0 | 1 reply | |
| 4/5 | dfu: Resolve Kconfig dependency loops | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support
Hi Alex,
Quoted 8 lines
Quoted 2 lines
- the USB and UDP code want consolidating, with this series there would then be two separate implementations of the same protocol
Yes - this is an issue.
For USB the fastboot protocol (at least some its logic) is implemented in
drivers/usb/gadget/f_fastboot.c
Quoted 6 lines
I think that some medium agnostic code (like protocol itself) can be unified.
I also think that it would be a good idea to have
./drivers/fastbootdirectory introduced to move common code there - and leave only USB related code inf_fastboot.c
Especially that we do have fb_nand.c and fb_mmc.c in ./common.
In that way we could move them to ./drivers/fastboot.
Quoted 2 lines
Please as a reference, look on how
./drivers/dfuis organised.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180425/83fe83f8/attachment.sig>