Fixing record/replay and adding reverse debugging
Get series with b4
b4 am 155074704329.32129.17530905097298071558.stgit@pasha-VirtualBoxVersions newest first · linked by author and title
- v13 Latest25 patches 14 repliesIn review
- v1225 patches 5 repliesSuperseded
- v1125 patches 0 repliesSuperseded
Earlier versions · 10
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v10 | 24 patches | 6 replies | Superseded | |
| v9 | 21 patches | 14 replies | Superseded | |
| v8 | 20 patches | 7 replies | Superseded | |
| v7 | 19 patches | 14 replies | Superseded | |
| v6 | 25 patches | 17 replies | Superseded | |
| v5 | 24 patches | 23 replies | Superseded | |
| v4 | 19 patches | 10 replies | Superseded | |
| v3 | 19 patches | 5 replies | Superseded | |
| v2 RFC | 19 patches | 4 replies | Superseded | |
| v1 RFC | 17 patches | 12 replies | Superseded |
Changes in v13 from the cover letter
- rebased to make QAPI stuff applicable
- minor reverse step/reverse continue fix
Patches in v13 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/25 | replay: add missing fix for internal functionreplay/ | +1 | 0 replies | |
| 2/25 | block: implement bdrv_snapshot_goto for blkreplayblock/ | +8 | 0 replies | |
| 3/25 | replay: disable default snapshot for record/replayvl.c | +8 | 0 replies | |
| 4/25 | replay: update docs for record/replay with block devicesdocs/ | +9 | 0 replies | |
| 5/25 | replay: don't drain/flush bdrv queue while RR is workingblock/ cpus.c | +28 | 0 replies | |
| 6/25 | replay: finish record/replay before closing the disksreplay/ vl.c | +3 | 0 replies | |
| 7/25 | qcow2: introduce icount field for snapshotsblock/ block/ docs/ | +13 | 0 replies | |
| 8/25 | migration: introduce icount field for snapshotsblock/ block/ blockdev.c +4 more | +40 | 0 replies | |
| 9/25 | replay: provide an accessor for rr filenameinclude/ replay/ | +7 | 0 replies | |
| 10/25 | qapi: introduce replay.json for record/replay-related stuffMAINTAINERS include/ qapi/ +3 more | +30 | 0 replies | |
| 11/25 | replay: introduce info hmp/qmp commandhmp-commands-info.hx hmp.h qapi/ +3 more | +101 | 0 replies | |
| 12/25 | replay: introduce breakpoint at the specified stephmp-commands.hx hmp.h qapi/ +3 more | +179 | 0 replies | |
| 13/25 | replay: implement replay-seek commandhmp-commands.hx hmp.h qapi/ +1 more | +132 | 0 replies | |
| 14/25 | replay: refine replay-time modulereplay/ | +16 | 0 replies | |
| 15/25 | replay: flush rr queue before loading the vmstateinclude/ migration/ replay/ | +8 | 0 replies | |
| 16/25 | gdbstub: add reverse step support in replay modeaccel/ cpus.c exec.c +4 more | +109 | 0 replies | |
| 17/25 | gdbstub: add reverse continue support in replay modecpus.c exec.c gdbstub.c +3 more | +99 | 0 replies | |
| 18/25 | replay: describe reverse debugging in docs/replay.txtdocs/ | +33 | 0 replies | |
| 19/25 | replay: add BH oneshot event for block layerblock/ block/ block/ +11 more | +57 | 13 replies | |
| 20/25 | replay: init rtc after enabling the replayvl.c | +7 | 0 replies | |
| 21/25 | replay: document development rulesdocs/ | +46 | 0 replies | |
| 22/25 | util/qemu-timer: refactor deadline calculation for external timerscpus.c include/ qtest.c +3 more | +44 | 0 replies | |
| 23/25 | replay: fix replay shutdownreplay/ | +4 | 0 replies | |
| 24/25 | replay: rename step-related variables and functionsblockdev.c include/ migration/ +7 more | +48 | 0 replies | |
| 25/25 | icount: clean up cpu_can_io before jumping to the next blockaccel/ | +2 | 0 replies |
Reviews trailers per patch
6 of 25 patches have a Reviewed-by or Acked-by.
| Patch | Kevin Wolf | Markus Armbruster | Dr. David Alan Gilbert |
|---|---|---|---|
| 1/25 | |||
| 2/25 | |||
| 3/25 | |||
| 4/25 | |||
| 5/25 | |||
| 6/25 | |||
| 7/25 | A-b | ||
| 8/25 | A-b | ||
| 9/25 | |||
| 10/25 | R-b | ||
| 11/25 | A-b | A-b | |
| 12/25 | A-b | ||
| 13/25 | A-b | ||
| 14/25 | |||
| 15/25 | |||
| 16/25 | |||
| 17/25 | |||
| 18/25 | |||
| 19/25 | |||
| 20/25 | |||
| 21/25 | |||
| 22/25 | |||
| 23/25 | |||
| 24/25 | |||
| 25/25 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v13 00/25] Fixing record/replay and adding reverse debugging
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.
Reverse debugging is possible in the replay mode, when at least one snapshot was created at the record or replay phase. QEMU can use these snapshots for travelling back in time with GDB.
Running the execution in replay mode allows using GDB reverse debugging commands:
- reverse-stepi (or rsi): Steps one instruction to the past. QEMU loads on of the prior snapshots and proceeds to the desired instruction forward. When that step is reaches, execution stops.
- reverse-continue (or rc): Runs execution "backwards". QEMU tries to find breakpoint or watchpoint by loaded prior snapshot and replaying the execution. Then QEMU loads snapshots again and replays to the latest breakpoint. When there are no breakpoints in the examined section of the execution, QEMU finds one more snapshot and tries again. After the first snapshot is processed, execution stops at this snapshot.
The set of patches include the following modifications:
- gdbstub update for reverse debugging support
- functions that automatically perform reverse step and reverse continue operations
- hmp/qmp commands for manipulating the replay process
- improvement of the snapshotting for saving the execution step in the snapshot parameters
- other record/replay fixes
The patches are available in the repository:
https://github.com/ispras/qemu/tree/rr-190221
v13 changes:
- rebased to make QAPI stuff applicable
- minor reverse step/reverse continue fix
v12 changes:
- style fixes
v11 changes:
- added can_do_io resetting before jumping to the next block in the chain
- rebase to the latest master
v10 changes:
- added patch for correct deadline calculation with external timers
- updated icount-related documentation in json files (suggested by Markus Armbruster)
- fixed replay shutdown
- renamed some functions and variables to make them consistent with the documentation and displayed messages
- minor changes
v9 changes:
- moved rr qapi stuff to the separate file (suggested by Markus Armbruster)
- minor coding style fixes
v8 changes:
- rebased to the new master
- added missing fix for prior rr patch
- updated 'since' version number in json-related patches
v7 changes:
- rebased to the new master with upstreamed patches from the series
- several improvements in hmp/qmp commands handling (suggested by Markus Armbruster)
- fixed record/replay with '-rtc base' option enabled
- added document with virtual hardware requirements
v6 changes:
- rebased to the new version of master
- fixed build of linux-user configurations
- added new clock for slirp and vnc timers
v5 changes:
- multiple fixes of record/replay bugs appeared after QEMU core update
- changed reverse debugging to 'since 3.1'
v4 changes:
- changed 'since 2.13' to 'since 3.0' in json (as suggested by Eric Blake)
v3 changes:
- Fixed PS/2 bug with save/load vm, which caused failures of the replay.
- Rebased to the new code base.
- Minor fixes.
v2 changes:
- documented reverse debugging
- fixed start vmstate loading in record mode
- documented qcow2 changes (as suggested by Eric Blake)
- made icount SnapshotInfo field optional (as suggested by Eric Blake)
- renamed qmp commands (as suggested by Eric Blake)
- minor changes
---
Pavel Dovgalyuk (24):
block: implement bdrv_snapshot_goto for blkreplay
replay: disable default snapshot for record/replay
replay: update docs for record/replay with block devices
replay: don't drain/flush bdrv queue while RR is working
replay: finish record/replay before closing the disks
qcow2: introduce icount field for snapshots
migration: introduce icount field for snapshots
replay: provide an accessor for rr filename
qapi: introduce replay.json for record/replay-related stuff
replay: introduce info hmp/qmp command
replay: introduce breakpoint at the specified step
replay: implement replay-seek command
replay: refine replay-time module
replay: flush rr queue before loading the vmstate
gdbstub: add reverse step support in replay mode
gdbstub: add reverse continue support in replay mode
replay: describe reverse debugging in docs/replay.txt
replay: add BH oneshot event for block layer
replay: init rtc after enabling the replay
replay: document development rules
util/qemu-timer: refactor deadline calculation for external timers
replay: fix replay shutdown
replay: rename step-related variables and functions
icount: clean up cpu_can_io before jumping to the next block
[email protected] (1):
replay: add missing fix for internal function
MAINTAINERS | 1 accel/tcg/tcg-runtime.c | 2 accel/tcg/translator.c | 1 block/blkreplay.c | 8 + block/block-backend.c | 8 + block/io.c | 32 ++++ block/iscsi.c | 5 - block/nfs.c | 5 - block/null.c | 4 - block/nvme.c | 6 + block/qapi.c | 18 ++ block/qcow2-snapshot.c | 9 + block/qcow2.h | 2 block/rbd.c | 5 - block/vxhs.c | 5 - blockdev.c | 10 + cpus.c | 30 +++- docs/devel/replay.txt | 46 ++++++ docs/interop/qcow2.txt | 4 + docs/replay.txt | 45 ++++++ exec.c | 8 + gdbstub.c | 52 +++++++ hmp-commands-info.hx | 14 ++ hmp-commands.hx | 53 +++++++ hmp.h | 4 + include/block/snapshot.h | 1 include/qemu/timer.h | 7 - include/sysemu/replay.h | 30 ++++ migration/savevm.c | 11 ++ qapi/Makefile.objs | 2 qapi/block-core.json | 8 + qapi/block.json | 3 qapi/misc.json | 18 -- qapi/qapi-schema.json | 1 qapi/replay.json | 121 +++++++++++++++++ qtest.c | 2 replay/Makefile.objs | 3 replay/replay-debugging.c | 327 +++++++++++++++++++++++++++++++++++++++++++++ replay/replay-events.c | 18 ++ replay/replay-internal.c | 10 + replay/replay-internal.h | 17 +- replay/replay-snapshot.c | 6 - replay/replay-time.c | 36 ++--- replay/replay.c | 56 ++++++-- stubs/Makefile.objs | 1 stubs/replay-user.c | 9 + stubs/replay.c | 10 + tests/ptimer-test-stubs.c | 2 tests/ptimer-test.c | 4 - util/qemu-timer.c | 41 +++++- vl.c | 21 ++- 51 files changed, 1009 insertions(+), 133 deletions(-) create mode 100644 docs/devel/replay.txt create mode 100644 qapi/replay.json create mode 100644 replay/replay-debugging.c create mode 100644 stubs/replay-user.c
Signature · 1 line
Pavel Dovgalyuk