pmic: sandbox: Add support for MC34709 PMIC
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest11 patches 0 repliesNew
- v211 patches 0 repliesSuperseded
- v15 patches 0 repliesSuperseded
Changes in v3 from the cover letter · 17 lines
- None
- None
- Rename dm_pmic_info to uc_pmic_priv
- Rename dm_pmic_info -> uc_pmic_priv
- Replace printf() -> debug()
- Use priv->trans_len instead of tx_num
- Rename dm_pmic_info with uc_pmic_priv
- Sort alphabetically includes
- Add comment regarding MC34708 byte ordering
- Replace dm_pmic_info with uc_pmic_priv
- Replace pmic_info with priv
- Replace pr_err() with debug()
- dm_pmic_info -> uc_pmic_priv
- Fix DTS property style to compy with Device Tree specification as suggested by Fabio.
- Enable MC34708 PMIC support in sandbox_{flattree|spl}_defconfig
- None
- Fix pmic.c test code after adjusting the sandbox PMIC related dts
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | pmic: fsl: Provide some more definitions for MC34708 PMICinclude/ | +40 | 1 reply | |
| 2/11 | pmic: fsl: Define number of bytes sent at once by MC34708 PMICinclude/ | +1 | 0 replies | |
| 3/11 | pmic: Add support for setting transmission length in uclass private datadrivers/ include/ | +19 | 0 replies | |
| 4/11 | pmic: dm: Rewrite pmic_reg_{read|write|clrsetbits} to support 3 bytes transmissionsdrivers/ | +30 | 0 replies | |
| 5/11 | pmic: dm: Add support for MC34708 for PMIC DMdrivers/ drivers/ drivers/ | +113 | 1 reply | |
| 6/11 | pmic: Rewrite the pmic command to not only work with single byte transmissioncmd/ | +19 | 0 replies | |
| 7/11 | sandbox: Rewrite i2c_pmic_emul.c to support PMIC with 3 bytes transmissiondrivers/ | +31 | 0 replies | |
| 8/11 | sandbox: Enable support for MC34708 PMIC in DTSarch/ arch/ arch/ +1 more | +45 | 0 replies | |
| 9/11 | sandbox: Enable MC34708 PMIC supportconfigs/ configs/ configs/ | +3 | 0 replies | |
| 10/11 | sandbox: tests: Exclude common test code (pmic_get) in test/dm/pmic.ctest/ | +10 | 0 replies | |
| 11/11 | sandbox: tests: Add tests for mc34708 PMIC devicetest/ | +56 | 0 replies |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Simon Glass |
|---|---|
| 1/11 | R-b |
| 2/11 | R-b |
| 3/11 | R-b |
| 4/11 | R-b |
| 5/11 | R-b |
| 6/11 | R-b |
| 7/11 | R-b |
| 8/11 | R-b |
| 9/11 | R-b |
| 10/11 | R-b |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH v3 00/11] pmic: sandbox: Add support for MC34709 PMIC
Adding this device required some changes into the PMIC uclass. Most notable one was the support for 3 bytes r/w operations. Moreover, emulation and tests for this device has been added to sandbox.
Travis-CI:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/378678458
Changes in v3:
- None
- None
- Rename dm_pmic_info to uc_pmic_priv
- Rename dm_pmic_info -> uc_pmic_priv
- Replace printf() -> debug()
- Use priv->trans_len instead of tx_num
- Rename dm_pmic_info with uc_pmic_priv
- Sort alphabetically includes
- Add comment regarding MC34708 byte ordering
- Replace dm_pmic_info with uc_pmic_priv
- Replace pmic_info with priv
- Replace pr_err() with debug()
- dm_pmic_info -> uc_pmic_priv
- Fix DTS property style to compy with Device Tree specification as suggested by Fabio.
- Enable MC34708 PMIC support in sandbox_{flattree|spl}_defconfig
- None
- Fix pmic.c test code after adjusting the sandbox PMIC related dts
Changes in v2:
- None
- None
- New patch
- pmic_reg_* fixes to use uclass private structure
- Support for uclass private data with trasfer length
- New patch
- New patch
- New patch
- New patch
- New patch
- New patch
Lukasz Majewski (11):
pmic: fsl: Provide some more definitions for MC34708 PMIC
pmic: fsl: Define number of bytes sent at once by MC34708 PMIC
pmic: Add support for setting transmission length in uclass private
data
pmic: dm: Rewrite pmic_reg_{read|write|clrsetbits} to support 3 bytes
transmissions
pmic: dm: Add support for MC34708 for PMIC DM
pmic: Rewrite the pmic command to not only work with single byte
transmission
sandbox: Rewrite i2c_pmic_emul.c to support PMIC with 3 bytes
transmission
sandbox: Enable support for MC34708 PMIC in DTS
sandbox: Enable MC34708 PMIC support
sandbox: tests: Exclude common test code (pmic_get) in test/dm/pmic.c
sandbox: tests: Add tests for mc34708 PMIC device
arch/sandbox/dts/sandbox.dts | 4 ++ arch/sandbox/dts/sandbox64.dts | 4 ++ arch/sandbox/dts/sandbox_pmic.dtsi | 33 ++++++++++++ arch/sandbox/dts/test.dts | 4 ++ cmd/pmic.c | 31 ++++++----- configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + configs/sandbox_spl_defconfig | 1 + drivers/power/pmic/Kconfig | 7 +++ drivers/power/pmic/Makefile | 1 + drivers/power/pmic/i2c_pmic_emul.c | 45 +++++++++++----- drivers/power/pmic/mc34708.c | 105 +++++++++++++++++++++++++++++++++++++ drivers/power/pmic/pmic-uclass.c | 52 +++++++++++++----- include/fsl_pmic.h | 41 +++++++++++++++ include/power/pmic.h | 9 ++++ test/dm/pmic.c | 68 +++++++++++++++++++++++- 16 files changed, 367 insertions(+), 40 deletions(-) create mode 100644 drivers/power/pmic/mc34708.c
Signature · 1 line
2.11.0