Skip to content

mtd: nand: davinci: stop using pdev->id as chipselect

Bartosz Golaszewski linux-arm-kernel linux-mtd lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12mtd: nand: davinci: store the core chipselect number in platform datainclude/linux/platform_data/mtd-davinci.h+2 -06 replies
2/12ARM: davinci: da830-evm: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-da830-evm.c+1 -00 replies
3/12ARM: davinci: da850-evm: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-da850-evm.c+1 -00 replies
4/12ARM: davinci: dm355-evm: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-dm355-evm.c+1 -00 replies
5/12ARM: davinci: dm355-leopard: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-dm355-leopard.c+1 -00 replies
6/12ARM: davinci: dm365-evm: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-dm365-evm.c+1 -00 replies
7/12ARM: davinci: dm644x-evm: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-dm644x-evm.c+1 -00 replies
8/12ARM: davinci: mityomapl138: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-mityomapl138.c+1 -00 replies
9/12ARM: davinci: dm646x-evm: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-dm646x-evm.c+1 -00 replies
10/12ARM: davinci: neuros-osd2: specify the chipselect in davinci_nand_pdataarch/arm/mach-davinci/board-neuros-osd2.c+1 -00 replies
11/12mtd: nand: davinci: stop using pdev->id as chipselectdrivers/mtd/nand/raw/davinci_nand.c+3 -30 replies
12/12ARM: davinci: aemif: stop using pdev->id as nand chipselectarch/arm/mach-davinci/aemif.c+4 -40 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Brezillon
SeriesA-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data
ARM: davinci: da830-evm: specify the chipselect in davinci_nand_pdata
ARM: davinci: da850-evm: specify the chipselect in davinci_nand_pdata
ARM: davinci: dm355-evm: specify the chipselect in davinci_nand_pdata
ARM: davinci: dm355-leopard: specify the chipselect in
davinci_nand_pdata
ARM: davinci: dm365-evm: specify the chipselect in davinci_nand_pdata
ARM: davinci: dm644x-evm: specify the chipselect in davinci_nand_pdata
ARM: davinci: mityomapl138: specify the chipselect in
davinci_nand_pdata
ARM: davinci: dm646x-evm: specify the chipselect in davinci_nand_pdata
ARM: davinci: neuros-osd2: specify the chipselect in
davinci_nand_pdata
mtd: nand: davinci: stop using pdev->id as chipselect
ARM: davinci: aemif: stop using pdev->id as nand chipselect

 arch/arm/mach-davinci/aemif.c               | 8 ++++----
 arch/arm/mach-davinci/board-da830-evm.c     | 1 +
 arch/arm/mach-davinci/board-da850-evm.c     | 1 +
 arch/arm/mach-davinci/board-dm355-evm.c     | 1 +
 arch/arm/mach-davinci/board-dm355-leopard.c | 1 +
 arch/arm/mach-davinci/board-dm365-evm.c     | 1 +
 arch/arm/mach-davinci/board-dm644x-evm.c    | 1 +
 arch/arm/mach-davinci/board-dm646x-evm.c    | 1 +
 arch/arm/mach-davinci/board-mityomapl138.c  | 1 +
 arch/arm/mach-davinci/board-neuros-osd2.c   | 1 +
 drivers/mtd/nand/raw/davinci_nand.c         | 6 +++---
 include/linux/platform_data/mtd-davinci.h   | 2 ++
 12 files changed, 18 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.0