Skip to content

hw/rdma: coverity fixes

Marcel Apfelbaum qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7hw/rdma: Fix possible munmap call on a NULL pointerhw/rdma/vmw/pvrdma_cmd.c+1 -10 replies
2/7hw/rdma: Fix possible usage of a NULL pointerhw/rdma/vmw/pvrdma_qp_ops.c+1 -01 reply
3/7hw/rdma: Delete port's pkey tablehw/rdma/rdma_rm_defs.h hw/rdma/vmw/pvrdma_main.c+1 -170 replies
4/7hw/rdma: Fix possible out of bounds access to GID tablehw/rdma/rdma_rm_defs.h hw/rdma/vmw/pvrdma_cmd.c+7 -30 replies
5/7hw/rdma: Fix possible out of bounds access to regs arrayhw/rdma/vmw/pvrdma.h hw/rdma/vmw/pvrdma_main.c+5 -50 replies
6/7hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAMEhw/rdma/rdma_rm.c hw/rdma/rdma_rm_defs.h+2 -40 replies
7/7hw/rdma: Fix possible out of bounds access to port GID indexhw/rdma/rdma_backend.c+1 -12 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchYuval ShaiaMarcel ApfelbaumPhilippe Mathieu-Daudé
1/7R-b
2/7R-b R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/7] hw/rdma: coverity fixes

From: Marcel Apfelbaum <[email protected]>

Various fixes that were found by coverity. (run by Peter, thanks!)

Thanks,
Marcel

Marcel Apfelbaum (3):
hw/rdma: Fix possible munmap call on a NULL pointer hw/rdma: Fix possible usage of a NULL pointer hw/rdma: Fix possible out of bounds access to port GID index

Yuval Shaia (4):
hw/rdma: Delete port's pkey table
hw/rdma: Fix possible out of bounds access to GID table hw/rdma: Fix possible out of bounds access to regs array hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME

 hw/rdma/rdma_backend.c      |  2 +-
 hw/rdma/rdma_rm.c           |  2 --
 hw/rdma/rdma_rm_defs.h      |  9 ++++-----
 hw/rdma/vmw/pvrdma.h        |  6 +++---
 hw/rdma/vmw/pvrdma_cmd.c    | 10 +++++++---
 hw/rdma/vmw/pvrdma_main.c   | 19 ++-----------------
 hw/rdma/vmw/pvrdma_qp_ops.c |  1 +
 7 files changed, 18 insertions(+), 31 deletions(-)
Signature · 1 line
2.14.3