Skip to content

get_short_oid UI improvements

Ævar Arnfjörð Bjarmason git 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 11 repliesIn review
  2. v312 patches 19 repliesSuperseded
  3. v212 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches10 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sha1-name.c: remove stray newlinesha1-name.c+0 -10 replies
2/6sha1-array.h: align function argumentssha1-array.c sha1-array.h+4 -43 replies
3/6git-p4: change "commitish" typo to "committish"git-p4.py+3 -31 reply
4/6sha1-name.c: move around the collect_ambiguous() functionsha1-name.c+6 -60 replies
5/6get_short_oid: sort ambiguous objects by type, then SHA-1Documentation/technical/api-oid-array.txt sha1-array.c sha1-array.h +2 more+88 -72 replies
6/6get_short_oid: document & warn if we ignore the type selectorsha1-name.c t/t1512-rev-parse-disambiguation.sh+14 -24 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchDerrick Stolee
1/6
2/6
3/6
4/6
5/6Helped-by
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] get_short_oid UI improvements

This is like v3 except all the patches to the peel syntax & docs have been dropped, which were controversial.

I think it's worthwhile to re-work that, but I don't have time for that now, so I'm submitting this. Maybe I'll have time in the future to re-work the rest, but then I can base it on top of this.

Ævar Arnfjörð Bjarmason (6):
sha1-name.c: remove stray newline
sha1-array.h: align function arguments
git-p4: change "commitish" typo to "committish" sha1-name.c: move around the collect_ambiguous() function
get_short_oid: sort ambiguous objects by type, then SHA-1
get_short_oid: document & warn if we ignore the type selector

 Documentation/technical/api-oid-array.txt | 17 ++++---
 git-p4.py                                 |  6 +--
 sha1-array.c                              | 21 +++++++-
 sha1-array.h                              |  7 ++-
 sha1-name.c                               | 61 +++++++++++++++++++----
 t/t1512-rev-parse-disambiguation.sh       | 26 +++++++++-
 6 files changed, 115 insertions(+), 23 deletions(-)
Signature · 1 line
2.17.0.410.g4ac3413cc8