firmware_loader changes for v4.18
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest14 patches 0 repliesNew
- v613 patches 8 repliesSuperseded
- v56 patches 4 repliesSuperseded
Changes in v7 from the cover letter
- Annoted Reviewed-by tags.
- Installed codespell and am now using checkpatch.sh --codespell to check each patch for spell check and blunders. Edited all files for corrections missed by other reviewers.
- checkpatch complained about using ---help--- when I moved the Kconfig file for the firmware loader so I replaced that now with what it suggests.
- fixed the other series of typos pickd up by reviewers
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | firmware: wrap FW_OPT_* into an enumdrivers/ drivers/ drivers/ +1 more | +42 | 0 replies | |
| 2/14 | firmware: use () to terminate kernel-doc function namesdrivers/ drivers/ | +15 | 0 replies | |
| 3/14 | firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()drivers/ drivers/ drivers/ +1 more | +14 | 0 replies | |
| 4/14 | firmware_loader: document firmware_sysfs_fallback()drivers/ | +20 | 0 replies | |
| 5/14 | firmware_loader: enhance Kconfig documentation over FW_LOADERdrivers/ | +131 | 0 replies | |
| 6/14 | firmware_loader: replace ---help--- with helpdrivers/ | +1 | 0 replies | |
| 7/14 | firmware_loader: move kconfig FW_LOADER entries to its own filedrivers/ drivers/ | +155 | 0 replies | |
| 8/14 | firmware_loader: make firmware_fallback_sysfs() print more usefuldrivers/ | +6 | 0 replies | |
| 9/14 | firmware: add firmware_request_nowarn() - load firmware without warningsDocumentation/ drivers/ include/ | +42 | 0 replies | |
| 10/14 | ath10k: use firmware_request_nowarn() to load firmwaredrivers/ | +1 | 0 replies | |
| 11/14 | ath10k: re-enable the firmware fallback mechanism for testmodedrivers/ | +1 | 0 replies | |
| 12/14 | Documentation: fix few typos and clarifications for the firmware loaderDocumentation/ Documentation/ | +5 | 0 replies | |
| 13/14 | Documentation: remove stale firmware API referenceDocumentation/ | +1 | 0 replies | |
| 14/14 | Documentation: clarify firmware_class provenance and why we can't rename the moduleDocumentation/ | +6 | 0 replies |
Reviews trailers per patch
13 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Kees Cook | Luis R. Rodriguez | Randy Dunlap | Kalle Valo | Mauro Carvalho Chehab |
|---|---|---|---|---|---|
| 1/14 | R-b | A-b | |||
| 2/14 | R-b | A-b | A-b | ||
| 3/14 | R-b | A-b | |||
| 4/14 | R-b | ||||
| 5/14 | R-b | ||||
| 6/14 | |||||
| 7/14 | R-b | ||||
| 8/14 | R-b | ||||
| 9/14 | R-b | A-b | |||
| 10/14 | R-b | A-b | |||
| 11/14 | R-b | A-b | |||
| 12/14 | R-b | ||||
| 13/14 | R-b | R-b | |||
| 14/14 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v7 00/14] firmware_loader changes for v4.18
Greg,
This is what I have queued up for the firmware_loader for v4.18. Below is a changelog of the changes, mostly addressing Andre's changes and a few other set of cleanups and documentation updates on my part and a few others pointed out by others.
Mimi will still be working on her changes later to add IMA firmware signature support, that should not touch the firmware loader code at all, and should help provide a generic alternative to the wireless regulatory signing work -- for all firmware.
Hans's EFI changes are still being worked on.
These changes are available in git form on my linux-next [0] and linux [1] trees on kernel.org on the branch name firmware_loader_for-v4.18. Hans, feel free to work off of that for your next iteration.
Questions, and specially rants are greatly appreciated.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20180510-firmware_loader_for-v4.18
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20180510-firmware_loader_for-v4.18
v7:
- Annoted Reviewed-by tags.
- Installed codespell and am now using checkpatch.sh --codespell to check each patch for spell check and blunders. Edited all files for corrections missed by other reviewers.
- checkpatch complained about using ---help--- when I moved the Kconfig file for the firmware loader so I replaced that now with what it suggests.
- fixed the other series of typos pickd up by reviewers
v6:
- Added the firmware_request_nowarn() patch again, now that we've decided on not to warn even for the fallback case.
v5:
- I took up Andres' patches and cleaned them up a bit further with minor details which would have otherwise have taken a few more iterations to do.
- Dropped the firmware_request_nowarn() patch since there was some inconsistencies over actually not warning on the fallback case
- Added some further firmware loader Kconfig clarifications which have come up through recent discussions.
- I dropped my firmware API rename changes for v4.18, so I adjusted Andres' patches accordingly.
v4:
- Andres removed the async nowarn API call firmware_request_nowait2() from his series, given we got into a discussion over how to properly
add a new async API to the firmware loader and there was no real consensus. Given I was tired of the bikeshedding I offered for folks recommend a solution and for us to just go with it. None solution was provided by any. To not leave Andres hanging during patch review, I made a set of recommendations but suggested that the asycn API be punted until *after* we get the simple sync nowarn API added. The recommendation still stands and my hope is that Andres will follow up with it later:
https://lkml.kernel.org/r/[email protected]
- Andres dropped the drm/amdgpu/brcmfmac driver changes based on feedback and becuase the async nowarn call was dropped in favor of addressing this later.
v3:
- Andres fixed typos picked up by Randy Dunlap.
v2:
- Andres added request_firmware_nowait2()
- Based on feedback Andres extended his patches to include use of the new API on the drivers amdgpu, ath10k and brcmfmac.
v1:
Andres only posted one patch to add request_firmware_optional() without any users
Andres Rodriguez (6):
firmware: wrap FW_OPT_* into an enum
firmware: use () to terminate kernel-doc function names
firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()
firmware: add firmware_request_nowarn() - load firmware without
warnings
ath10k: use firmware_request_nowarn() to load firmware
ath10k: re-enable the firmware fallback mechanism for testmode
Luis R. Rodriguez (8):
firmware_loader: document firmware_sysfs_fallback()
firmware_loader: enhance Kconfig documentation over FW_LOADER
firmware_loader: replace ---help--- with help
firmware_loader: move kconfig FW_LOADER entries to its own file
firmware_loader: make firmware_fallback_sysfs() print more useful
Documentation: fix few typos and clarifications for the firmware
loader
Documentation: remove stale firmware API reference
Documentation: clarify firmware_class provenance and why we can't
rename the module
Documentation/dell_rbu.txt | 5 +- .../firmware/fallback-mechanisms.rst | 14 +- .../driver-api/firmware/firmware_cache.rst | 4 +- .../driver-api/firmware/request_firmware.rst | 5 + drivers/base/Kconfig | 90 ++-------- drivers/base/firmware_loader/Kconfig | 154 ++++++++++++++++++ drivers/base/firmware_loader/fallback.c | 53 ++++-- drivers/base/firmware_loader/fallback.h | 18 +- drivers/base/firmware_loader/firmware.h | 37 ++++- drivers/base/firmware_loader/main.c | 57 +++++-- drivers/net/wireless/ath/ath10k/core.c | 2 +- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- include/linux/firmware.h | 10 ++ 13 files changed, 320 insertions(+), 131 deletions(-) create mode 100644 drivers/base/firmware_loader/Kconfig
Signature · 1 line
2.17.0