Skip to content

xfs: skip unnecessary discards

Brian Foster linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 14 repliesIn review
  2. v14 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Minor cleanups.
- Dropped the eofblocks unwritten extent rfc.
v1: https://marc.info/?l=linux-xfs&m=152571670220480&w=2
- Define and use bmapi flag for eofblocks trims.
- Separate patch to skip discards of unwritten extents.
- Various factoring cleanups.
rfc: https://marc.info/?l=linux-xfs&m=152476598825563&w=2

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: add bmapi nodiscard flagfs/xfs/libxfs/xfs_alloc.c fs/xfs/libxfs/xfs_alloc.h fs/xfs/libxfs/xfs_bmap.c +4 more+85 -1710 replies
2/3xfs: skip online discard during eofblocks trimsfs/xfs/xfs_bmap_util.c fs/xfs/xfs_inode.c fs/xfs/xfs_inode.h+35 -122 replies
3/3xfs: don't discard on free of unwritten extentsfs/xfs/libxfs/xfs_bmap.c+2 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] xfs: skip unnecessary discards

Hi all,

Here's v2 of the skip discards series. The only difference from the previous version is some factoring cleanups. This has since passed more (online discard enabled) xfstests runs without exploding.

Thoughts, reviews, flames appreciated.

Brian

v2:
- Minor cleanups.
- Dropped the eofblocks unwritten extent rfc.
v1: https://marc.info/?l=linux-xfs&m=152571670220480&w=2
- Define and use bmapi flag for eofblocks trims.
- Separate patch to skip discards of unwritten extents.
- Various factoring cleanups.
rfc: https://marc.info/?l=linux-xfs&m=152476598825563&w=2

Brian Foster (3):
xfs: add bmapi nodiscard flag
xfs: skip online discard during eofblocks trims
xfs: don't discard on free of unwritten extents

 fs/xfs/libxfs/xfs_alloc.c  | 10 +++++++---
 fs/xfs/libxfs/xfs_alloc.h  | 27 +++++++++++++++++++++++++--
 fs/xfs/libxfs/xfs_bmap.c   | 18 ++++++++++++++----
 fs/xfs/libxfs/xfs_bmap.h   | 30 ++++++++++++++++++++++++++++--
 fs/xfs/xfs_bmap_util.c     |  4 ++--
 fs/xfs/xfs_extfree_item.c  |  2 +-
 fs/xfs/xfs_inode.c         | 19 +++++++++++--------
 fs/xfs/xfs_inode.h         | 24 ++++++++++++++++++++++--
 fs/xfs/xfs_trans.h         |  3 ++-
 fs/xfs/xfs_trans_extfree.c | 13 +++++++++----
 10 files changed, 121 insertions(+), 29 deletions(-)
Signature · 1 line
2.14.3