Skip to content

Fix mem leaks of recent object store conversions.

Stefan Beller git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v12 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4packfile: close and free packs upon releasing an object storeobject.c packfile.c packfile.h+15 -30 replies
2/4packfile.h: remove all extern keywordspackfile.h+40 -400 replies
3/4object.c: free replace map in raw_object_store_clearobject.c+3 -00 replies
4/4replace-object.c: remove the_repository from prepare_replace_objectreplace-object.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] Fix mem leaks of recent object store conversions.

This series replaces the two commits that were queued on sb/object-store-replace, fixing memory leaks that were recently introduced.

Compared to v1, I merged the two independent series from yesterday, rewrote the commit message to clear up Junios confusion and addresses Peffs comments for the packfiles as well.
Also added another free to free the oidmap for the replaces themselves.

Thanks,
Stefan

Stefan Beller (4):
packfile: close and free packs upon releasing an object store packfile.h: remove all extern keywords
object.c: free replace map in raw_object_store_clear replace-object.c: remove the_repository from prepare_replace_object

 object.c         |  7 +++--
 packfile.c       | 13 ++++++++
 packfile.h       | 79 ++++++++++++++++++++++++------------------------
 replace-object.c |  2 +-
 4 files changed, 58 insertions(+), 43 deletions(-)
Signature · 1 line
2.17.0.255.g8bfb7c0704