completion: avoid hard coding config var list
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest11 patches 3 repliesIn review
- v19 patches 11 repliesSuperseded
Changes in v2 from the cover letter
- based on 'next'
- C99 is now mentioned in the commit message
- fixed Eric's comments
- the old 8/9 partial case-insensitive support patch is replaced with Szeder's version.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | Add and use generic name->id mapping code for color slot parsingbuiltin/ builtin/ builtin/ +4 more | +82 | 1 reply | |
| 2/11 | grep: keep all colors in an arraygrep.c grep.h | +62 | 0 replies | |
| 3/11 | fsck: factor out msg_id_info[] lazy initialization codefsck.c | +24 | 0 replies | |
| 4/11 | help: add --config to list all available configDocumentation/ advice.c builtin/ +10 more | +172 | 1 reply | |
| 5/11 | fsck: produce camelCase config key namesfsck.c | +18 | 0 replies | |
| 6/11 | advice: keep config name in camelCase in advice_config[]advice.c | +21 | 0 replies | |
| 7/11 | am: move advice.amWorkDir parsing back to advice.cadvice.c advice.h builtin/ +1 more | +5 | 0 replies | |
| 8/11 | completion: drop the hard coded list of config varsbuiltin/ contrib/ help.c +1 more | +49 | 0 replies | |
| 9/11 | completion: keep other config var completion in camelCasecontrib/ | +6 | 0 replies | |
| 10/11 | completion: support case-insensitive config varscontrib/ | +9 | 0 replies | |
| 11/11 | log-tree: allow to customize 'grafted' colorDocumentation/ log-tree.c | +3 | 1 reply |
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by.
| Patch | SZEDER Gábor |
|---|---|
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | Helped-by |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/11] completion: avoid hard coding config var list
v2 changes:
- based on 'next'
- C99 is now mentioned in the commit message
- fixed Eric's comments
- the old 8/9 partial case-insensitive support patch is replaced with Szeder's version.
Szeder I claimed authorship because I wrote the commit message which may not be what you like. If you want to claim it instead, I'll be glad to resend.
- There is no levenshtein support yet. But the code is updated to keep this config list in memory instead of printf'ing directly to make it easier in the future to do that.
Nguyễn Thái Ngọc Duy (11):
Add and use generic name->id mapping code for color slot parsing
grep: keep all colors in an array
fsck: factor out msg_id_info[] lazy initialization code
help: add --config to list all available config
fsck: produce camelCase config key names
advice: keep config name in camelCase in advice_config[]
am: move advice.amWorkDir parsing back to advice.c
completion: drop the hard coded list of config vars
completion: keep other config var completion in camelCase
completion: support case-insensitive config vars
log-tree: allow to customize 'grafted' color
Documentation/config.txt | 3 +- Documentation/git-help.txt | 5 + advice.c | 53 ++-- advice.h | 1 + builtin/am.c | 6 +- builtin/branch.c | 29 +- builtin/clean.c | 29 +- builtin/commit.c | 36 +-- builtin/help.c | 16 ++ config.c | 13 + config.h | 4 + contrib/completion/git-completion.bash | 357 ++----------------------- diff.c | 56 ++-- fsck.c | 68 +++-- generate-cmdlist.sh | 19 ++ grep.c | 109 ++++---- grep.h | 21 +- help.c | 84 ++++++ help.h | 45 +++- log-tree.c | 37 +-- t/t4254-am-corrupt.sh | 2 +- 21 files changed, 440 insertions(+), 553 deletions(-)
Signature · 1 line
2.17.0.705.g3525833791