Skip to content

RFC Fix UART serial implementation

Calvin Lee qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest2 patches 3 repliesIn review
  2. v1 RFC2 patches 0 repliesSuperseded

Changes in v2 from the cover letter

fix build

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PC Chipset: Improve serial divisor calculationhw/char/serial.c+13 -100 replies
2/2PC Chipset: Send serial bytes at correct ratehw/char/serial.c include/hw/char/serial.h+47 -62 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation

Hello,

While developing a serial implementation for my OS, I found several bugs in QEMU's serial device. I confirmed (by testing on my x64 laptop) that there are several inconsistancies between QEMU and hardware in this regard. For both patches, I used "http://www.sci.muni.cz/docs/pc/serport.txt" for reference.

First, QEMU has several errors for setting the UART divisor that are fixed in my first patch. Second, (and more importantly) QEMU does not transmit serial bytes at the correct rate, and this is fixed in my second patch.

I have neither contributed to QEMU nor sent patches to a mailing list before, so I marked this patch-series as RFC. I would appreciate any comments you have. Also, I am not very confident in VM migration between versions, so I would appreciate if someone could help me make sure this is correct in my patches.

v2:
fix build

Calvin Lee (2):
PC Chipset: Improve serial divisor calculation
PC Chipset: Send serial bytes at correct rate

 hw/char/serial.c         | 74 +++++++++++++++++++++++++++++++---------
 include/hw/char/serial.h |  2 ++
 2 files changed, 60 insertions(+), 16 deletions(-)
Signature · 1 line
2.17.0

Read the cover letter in its thread