Skip to content

Netfilter/IPVS fixes for net

Pablo Neira Ayuso netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15netfilter: Fix handling simultaneous open in TCP conntrackinclude/uapi/linux/netfilter/nf_conntrack_tcp.h net/netfilter/nf_conntrack_proto_tcp.c+14 -00 replies
2/15netfilter: x_tables: check name length in find_match/target, toonet/netfilter/x_tables.c+6 -00 replies
3/15netfilter: nf_tables: skip synchronize_rcu if transaction log is emptynet/netfilter/nf_tables_api.c+17 -80 replies
4/15netfilter: bridge: stp fix reference to uninitialized datanet/bridge/netfilter/ebt_stp.c+2 -20 replies
5/15netfilter: nf_tables: nft_compat: fix refcount leak on xt modulenet/netfilter/nft_compat.c+58 -340 replies
6/15ipvs: fix refcount usage for conns in ops modenet/netfilter/ipvs/ip_vs_conn.c+6 -110 replies
7/15ipvs: fix stats update from local clientsnet/netfilter/ipvs/ip_vs_core.c+12 -00 replies
8/15netfilter: core: add missing __rcu annotationnet/netfilter/core.c+2 -10 replies
9/15netfilter: prefer nla_strlcpy for dealing with NLA_STRING attributesnet/netfilter/nfnetlink_acct.c net/netfilter/nfnetlink_cthelper.c+5 -40 replies
10/15netfilter: x_tables: add module alias for icmp matchesnet/ipv4/netfilter/ip_tables.c net/ipv6/netfilter/ip6_tables.c+2 -00 replies
11/15netfilter: nf_tables: don't assume chain stats are set when jumplabel is setnet/netfilter/nf_tables_core.c+14 -70 replies
12/15netfilter: nft_compat: prepare for indirect info storagenet/netfilter/nft_compat.c+36 -110 replies
13/15netfilter: nft_compat: fix handling of large matchinfo sizenet/netfilter/nft_compat.c+63 -10 replies
14/15netfilter: nf_tables: bogus EBUSY in chain deletionsinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_immediate.c+59 -70 replies
15/15netfilter: nf_tables: fix memory leak on error exit returnnet/netfilter/nf_tables_api.c+4 -20 replies

Reviews trailers per patch

2 of 15 patches have a Reviewed-by or Acked-by.

PatchDominique MartinetTaehee YooSimon Horman
1/15T-b
2/15
3/15
4/15
5/15T-b
6/15A-b
7/15A-b
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/15] Netfilter/IPVS fixes for net

Hi David,

The following patchset contains Netfilter/IPVS fixes for your net tree, they are:

1) Fix handling of simultaneous open TCP connection in conntrack, from Jozsef Kadlecsik.

2) Insufficient sanitify check of xtables extension names, from Florian Westphal.

3) Skip unnecessary synchronize_rcu() call when transaction log is already empty, from Florian Westphal.

4) Incorrect destination mac validation in ebt_stp, from Stephen Hemminger.

5) xtables module reference counter leak in nft_compat, from Florian Westphal.

6) Incorrect connection reference counting logic in IPVS one-packet scheduler, from Julian Anastasov.

7) Wrong stats for 32-bits CPU in IPVS, also from Julian.

8) Calm down sparse error in netfilter core, also from Florian.

9) Use nla_strlcpy to fix compilation warning in nfnetlink_acct and nfnetlink_cthelper, again from Florian.

10) Missing module alias in icmp and icmp6 xtables extensions, from Florian Westphal.

11) Base chain statistics in nf_tables may be unset/null, from Florian.

12) Fix handling of large matchinfo size in nft_compat, this includes one preparation for before this fix. From Florian.

13) Fix bogus EBUSY error when deleting chains due to incorrect reference counting from the preparation phase of the two-phase commit protocol.

You can pull these changes from:

git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git

Thanks.

----------------------------------------------------------------

The following changes since commit 25eb0ea7174c6e84f21fa59dccbddd0318b17b12:

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf (2018-04-25 22:55:33 -0400)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD

for you to fetch changes up to f0dfd7a2b35b02030949100247d851b793cb275f:

netfilter: nf_tables: fix memory leak on error exit return (2018-05-14 00:21:59 +0200)

----------------------------------------------------------------
Colin Ian King (1):
netfilter: nf_tables: fix memory leak on error exit return

Florian Westphal (9):
netfilter: x_tables: check name length in find_match/target, too
netfilter: nf_tables: skip synchronize_rcu if transaction log is empty
netfilter: nf_tables: nft_compat: fix refcount leak on xt module
netfilter: core: add missing __rcu annotation
netfilter: prefer nla_strlcpy for dealing with NLA_STRING attributes
netfilter: x_tables: add module alias for icmp matches
netfilter: nf_tables: don't assume chain stats are set when jumplabel is set
netfilter: nft_compat: prepare for indirect info storage
netfilter: nft_compat: fix handling of large matchinfo size

Jozsef Kadlecsik (1):
netfilter: Fix handling simultaneous open in TCP conntrack

Julian Anastasov (2):
ipvs: fix refcount usage for conns in ops mode
ipvs: fix stats update from local clients

Pablo Neira Ayuso (1):
netfilter: nf_tables: bogus EBUSY in chain deletions

Stephen Hemminger (1):
netfilter: bridge: stp fix reference to uninitialized data

 include/net/netfilter/nf_tables.h               |   5 +
 include/uapi/linux/netfilter/nf_conntrack_tcp.h |   3 +
 net/bridge/netfilter/ebt_stp.c                  |   4 +-
 net/ipv4/netfilter/ip_tables.c                  |   1 +
 net/ipv6/netfilter/ip6_tables.c                 |   1 +
 net/netfilter/core.c                            |   3 +-
 net/netfilter/ipvs/ip_vs_conn.c                 |  17 +-
 net/netfilter/ipvs/ip_vs_core.c                 |  12 ++
 net/netfilter/nf_conntrack_proto_tcp.c          |  11 ++
 net/netfilter/nf_tables_api.c                   |  77 +++++++--
 net/netfilter/nf_tables_core.c                  |  21 ++-
 net/netfilter/nfnetlink_acct.c                  |   2 +-
 net/netfilter/nfnetlink_cthelper.c              |   7 +-
 net/netfilter/nft_compat.c                      | 201 ++++++++++++++++++------
 net/netfilter/nft_immediate.c                   |  15 +-
 net/netfilter/x_tables.c                        |   6 +
 16 files changed, 299 insertions(+), 87 deletions(-)